impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker
Date Mon, 11 Dec 2017 19:38:51 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 )

Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker
......................................................................


Patch Set 2:

(1 comment)

Code looks good, just a couple more things.

http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc@334
PS2, Line 334:   IntGauge* negated_bytes_in_use = new NegatedGauge<int64_t>(
We should add the gauges to obj_pool_.

I think this also needs to be skipped if we're not using TCMalloc (we could move it into the
#if below).



-- 
To view, visit http://gerrit.cloudera.org:8080/8782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I602e9d5e8e8d7470dcfe4addde3265057c16263a
Gerrit-Change-Number: 8782
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 19:38:51 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message