impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Date Mon, 11 Dec 2017 18:35:01 GMT
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807
)

Change subject: IMPALA-6301: Fix test failures when username or group name contains dots
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test:

http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@155
PS2, Line 155: $GROUP_NAME
It looks like you didn't quote any of the revoke statements. Do they work without the quotes?


http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@494
PS2, Line 494: $GROUP_NAME
quote?



-- 
To view, visit http://gerrit.cloudera.org:8080/8807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b
Gerrit-Change-Number: 8807
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 18:35:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message