impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Jin Chul (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive
Date Mon, 11 Dec 2017 10:59:46 GMT
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )

Change subject: IMPALA-2640: Make a given command case-sensitive
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_commandline.py@585
PS7, Line 585:   def run_simple_command(self, command):
             :     run_impala_shell_cmd('-q "%s;"' % command)
             : 
             :   def test_commands(self):
             :     """Testing commands which have not been tested"""
             :     self.run_simple_command("help")
> Why is this test added with this change?
These methods are unnecessary. They were introduced due to the code change for do_help at
the patch set #5. See the line 1168 in 
https://gerrit.cloudera.org/#/c/8762/5..7/shell/impala_shell.py


http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_interactive.py@401
PS7, Line 401:       # IMPALA-5416: Test that a command following 'source' won't be run twice.
             :       result = run_impala_shell_interactive(
             :         "source shell_case_sensitive.cmds;select \"second command\";")
> The IMPALA-5416 part is a leftover from copy-pasting test_source_file. "sel
Thanks for finding this. It's my mistake. Let me remove the invalid comment.



-- 
To view, visit http://gerrit.cloudera.org:8080/8762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 7
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Andre Araujo <araujo@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 10:59:46 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message