impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM
Date Fri, 08 Dec 2017 22:37:58 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 )

Change subject: IMPALA-6291: disable AVX512 codegen in LLVM
......................................................................


Patch Set 3:

Right, I'm sure it calls getHostCpuFeatures() like we do, which is this lovely function: http://llvm.org/doxygen/Host_8cpp_source.html#l01129

Michael's suggestion, if I understood it correctly, was to alter our CpuInfo based on this
flag, which would require translating llvm's names into our own CpuInfo flags.


-- 
To view, visit http://gerrit.cloudera.org:8080/8802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a
Gerrit-Change-Number: 8802
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 22:37:58 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message