impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM
Date Fri, 08 Dec 2017 21:34:25 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 )

Change subject: IMPALA-6291: disable AVX512 codegen in LLVM
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@110
PS2, Line 110: DEFINE_string(llvm_cpu_attr_whitelist, "sse2,cx16,prfchw,bmi2,fsgsbase,popcnt,aes,smap,"
> May be my question wasn't quite clear.
Oh I see. Yeah I think that could cause us to hit LLVM asserts. Definitely a user could cause
all sorts of bad behaviour by tweaking this flag.

Do you think marking it (Experimental) is sufficient to discourage people from thinking that
it is safe to play with, or should I make it totally hidden?



-- 
To view, visit http://gerrit.cloudera.org:8080/8802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a
Gerrit-Change-Number: 8802
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 21:34:25 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message