impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Tran (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format
Date Fri, 08 Dec 2017 21:14:00 GMT
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 )

Change subject: IMPALA-5315: Cast to timestamp fails for YYYY-M-D format
......................................................................


Patch Set 5:

I ran 3 trials on both the old path and the new path (on-the-flight template generation for
all cases) 
select min(cast (time_string as timestamp)) from private.impala_5315

Where impala_5315 contains 3.87B rows.

The result is pretty consistent between the three trials:

The AGGR node takes 2x the time to run when the template needs to be generated on the flight.
The time difference is in AGGR NODE BuildTime. I haven't figured out why this is yet. Looking
for input and ideas.


Old path:
http://github.mtv.cloudera.com/gist/vttran/32f18cecd5b277dade0da72fa561084d

New path:
http://github.mtv.cloudera.com/gist/vttran/91de8682521e405f230f565a00bcd22a


-- 
To view, visit http://gerrit.cloudera.org:8080/7009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f
Gerrit-Change-Number: 7009
Gerrit-PatchSet: 5
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 21:14:00 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message