impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'
Date Thu, 07 Dec 2017 20:37:57 GMT
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 )

Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'
......................................................................


Patch Set 1:

Nice catch ! Do we have a similar problem with the FCMP instruction in LlvmCodeGen::CodegenMinMax()
?


-- 
To view, visit http://gerrit.cloudera.org:8080/8790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb8e5074b3c939927dedc46bc9db63ca24486a1
Gerrit-Change-Number: 8790
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 20:37:57 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message