impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.
Date Thu, 07 Dec 2017 17:59:43 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 )

Change subject: IMPALA-6285: Don't print stack trace on RPC errors.
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

I'm assuming Sailesh is happy with this based on his previous comment.

http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h
File be/src/runtime/client-cache.h:

http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h@314
PS2, Line 314:     return Status::Expected(msg);
This idiom is a bit inefficient - i think it results in three copies of the string - first
to construct it, then to copy it into the ErrorMsg, then to copy it into a new ErrorMsg in
the status. It probably doesn't really matter though.


http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h@329
PS2, Line 329:       VLOG_QUERY << msg.msg() << " rpc: " << typeid(*response).name();
Should we also include the typeid() in the Status? Or is thta overkill?



-- 
To view, visit http://gerrit.cloudera.org:8080/8788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58
Gerrit-Change-Number: 8788
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 17:59:43 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message