impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Borok-Nagy (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive
Date Thu, 07 Dec 2017 11:27:30 GMT
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762
)

Change subject: IMPALA-2640: Make a given command case-sensitive
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@303
PS6, Line 303: beewax
spelling issue: it's beeswax, not beewax


http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@551
PS6, Line 551:     This may be overridden, but should not normally need to be;
             :     see the precmd() and postcmd() methods for useful execution hooks.
             :     The return value is a flag indicating whether interpretation of
             :     commands by the interpreter should stop.
This comment shouldn't be here


http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@572
PS6, Line 572: return func(arg, cmd_)
To me it looks a bit weird to pass the command string to each command.
After looking into Cmd.cmdloop(), maybe you could store the typed command in precmd() or in
this function, then use it in _create_beeswax_query(). It would require far less code modifications
also.



-- 
To view, visit http://gerrit.cloudera.org:8080/8762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 6
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Andre Araujo <araujo@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 11:27:30 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message