impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Borok-Nagy (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Date Thu, 07 Dec 2017 10:18:13 GMT
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670
)

Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc
File be/src/util/runtime-profile-test.cc:

http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc@630
PS2, Line 630:       if (csw_.TotalRunningTime() > 3000000000) {
Might need to update this check as well.


http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc@631
PS2, Line 631: EXPECT_FALSE(false);
It wasn't introduced in this commit, but to my understanding EXPECT_FALSE(false) is a no-op,
it doesn't fail the test.



-- 
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 10:18:13 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message