impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Jin Chul (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell
Date Thu, 07 Dec 2017 04:58:45 GMT
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 )

Change subject: IMPALA-4664: Unexpected string conversion in Shell
......................................................................


Patch Set 4:

> Here is my assumption. I guess we need to customize sqlparse to consume Impala syntax
and sqlparse can recognize Impala's version to decide a set of available syntax.

I would like to clarify the above comment. I meant syntactical analyzer(not semantic analyzer).
Here is additional explanation why the customization is required. For example, Impala 3.0
introduce a new keyword, but sqlparse does not support the keyword officially. We may need
to manage the keywords with Impala's version. Please see the case of postgreSQL: https://github.com/andialbrecht/sqlparse/blob/master/sqlparse/keywords.py#L805


-- 
To view, visit http://gerrit.cloudera.org:8080/8639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6fa4e9ac570d22135ba51b844db8f9be965ca3
Gerrit-Change-Number: 8639
Gerrit-PatchSet: 4
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 04:58:45 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message