impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()
Date Wed, 06 Dec 2017 19:15:56 GMT
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 )

Change subject: IMPALA-6281: Fix use-after-free in InitAuth()
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8777/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8777/1//COMMIT_MSG@9
PS1, Line 9: Previously, we implicitly create a local string object created from
nit: can you briefly mention why this was found now / when it was introduced. I saw that you
explained it in the JIRA but it may be helpful to include it here, too.


http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/rpc-mgr-test.cc
File be/src/rpc/rpc-mgr-test.cc:

http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/rpc-mgr-test.cc@57
PS1, Line 57: static string current_executable_path;
Should we make this a char* (and spell all uppercase)?


http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/thrift-server-test.cc
File be/src/rpc/thrift-server-test.cc:

http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/thrift-server-test.cc@94
PS1, Line 94: static string current_executable_path;
Change to char*, upper case?


http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/transport/TSasl.h
File be/src/transport/TSasl.h:

http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/transport/TSasl.h@213
PS1, Line 213: life cycle
nit: lifetime



-- 
To view, visit http://gerrit.cloudera.org:8080/8777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f29c2396df114264dfc23726b8ba778f50e12e9
Gerrit-Change-Number: 8777
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 19:15:56 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message