impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs
Date Wed, 06 Dec 2017 17:00:42 GMT
Laszlo Gaal has posted comments on this change. ( )

Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

Patch Set 5:

File bin/
PS4, Line 82:   # an EC2 VM) or the IAM role cannot be retrieved.
> Please make this IP address a shell variable and set it above right after y

Also added a brief description of the instance metadata access mechanism and a link to the
relevant AWS doc page.
File bin/
PS4, Line 345: if (set +x; [[ -n ${AWS_SESSION_TOKEN-} ]]); then
> It's confusing that this is backwards from line 334 and 324. i.e., in the f
PS4, Line 353:     export DEFAULT_FS="s3a://${S3_BUCKET}"
             :     export FILESYSTEM
> nit:
File fe/src/test/java/org/apache/impala/analysis/
PS4, Line 3000: 
> If we believe this is tested in the e2e tests, I think it's fine to remove 
For the record: I ended up removing it after running load.test both for S3 and HDFS.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cd9d4453a91baad3c379aa7e4944993fca95ae
Gerrit-Change-Number: 8294
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Zach Amsden <>
Gerrit-Comment-Date: Wed, 06 Dec 2017 17:00:42 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message