impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs
Date Wed, 06 Dec 2017 17:00:42 GMT
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 )

Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8294/4/bin/check-s3-access.sh
File bin/check-s3-access.sh:

http://gerrit.cloudera.org:8080/#/c/8294/4/bin/check-s3-access.sh@82
PS4, Line 82:   # an EC2 VM) or the IAM role cannot be retrieved.
> Please make this IP address a shell variable and set it above right after y
Done

Also added a brief description of the instance metadata access mechanism and a link to the
relevant AWS doc page.


http://gerrit.cloudera.org:8080/#/c/8294/4/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/8294/4/bin/impala-config.sh@345
PS4, Line 345: if (set +x; [[ -n ${AWS_SESSION_TOKEN-} ]]); then
> It's confusing that this is backwards from line 334 and 324. i.e., in the f
Done


http://gerrit.cloudera.org:8080/#/c/8294/4/bin/impala-config.sh@353
PS4, Line 353:     export DEFAULT_FS="s3a://${S3_BUCKET}"
             :     export FILESYSTEM
> nit:
Done


http://gerrit.cloudera.org:8080/#/c/8294/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:

http://gerrit.cloudera.org:8080/#/c/8294/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@a3000
PS4, Line 3000: 
> If we believe this is tested in the e2e tests, I think it's fine to remove 
For the record: I ended up removing it after running load.test both for S3 and HDFS.



-- 
To view, visit http://gerrit.cloudera.org:8080/8294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cd9d4453a91baad3c379aa7e4944993fca95ae
Gerrit-Change-Number: 8294
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 17:00:42 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message