impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure
Date Tue, 05 Dec 2017 22:51:01 GMT
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 )

Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8754/1/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

http://gerrit.cloudera.org:8080/#/c/8754/1/be/src/runtime/coordinator-backend-state.cc@457
PS1, Line 457: profile_->Update(exec_status.profile);
> Done
yeah, if Prepare is finished, we do explicitly want to guarantee that there is a runtime-state
(that's documented in the header above the member fields) which is guaranteed to have a profile.
 So I agree this should be a dcheck.



-- 
To view, visit http://gerrit.cloudera.org:8080/8754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f581c7c8039f02a33712515c5bffab942309bba
Gerrit-Change-Number: 8754
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 22:51:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message