impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence
Date Tue, 05 Dec 2017 19:02:45 GMT
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 )

Change subject: IMPALA-6190/6246: Add instances tab and event sequence
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> Can you link to a full profile that shows the new info, and also a screenshot of the
webpages?

Sure, I added both to a gist here: https://gist.github.com/lekv/886926d8ce1f76c1d033ed01ae389732

In the profiles you'll see that the instances already have timers to measure the duration
of Open(), Prepare(), and Exec(). Should we keep these? Let me know if you'd like me to add
a profile to the change temporarily so we can discuss it using review comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/8758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I626456b6afa9101eeeeffd5cda10c4096d63d7f9
Gerrit-Change-Number: 8758
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 19:02:45 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message