impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive
Date Sat, 02 Dec 2017 00:11:21 GMT
Zach Amsden has uploaded a new patch set (#2). ( )

Change subject: IMPALA-6245: Tolerate column indenting from Hive

IMPALA-6245: Tolerate column indenting from Hive

The fix for HIVE-3140 started indenting multi-line comments,
which breaks Impala testing when run against Hive 2.1.1.

To test this using the pure test runner proved difficult
since it would require extensive changes to support both
row_regexes (since the columns changed order) and subset
support (since the number of rows changed).

Instead, we manually verify the hints are present in the
output in the python test.

The fact that the hints have been reformatted leaves us
in an uncertain state as to whether they actually get applied,
so a new test case has been added to run EXPLAIN SELECT
on the view and verify the joins happen exactly as we

Testing: Ran the views-ddl test against Impala mini-cluster
setups using both Hive 2.1.1 and Hive 1.1.0

Change-Id: I49e53b1230520ca6e850af28078526e6627d69de
M testdata/workloads/functional-query/queries/QueryTest/views-ddl.test
M tests/metadata/
2 files changed, 50 insertions(+), 22 deletions(-)

  git pull ssh:// refs/changes/19/8719/2
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49e53b1230520ca6e850af28078526e6627d69de
Gerrit-Change-Number: 8719
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message