impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6265 Increase timeout in test cancellation tests
Date Fri, 01 Dec 2017 17:40:46 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8713 )

Change subject: IMPALA-6265 Increase timeout in test cancellation tests
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8713/1/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/8713/1/tests/shell/test_shell_commandline.py@352
PS1, Line 352:     sleep(2.5)
It would be nice to set this to a higher value for ASAN just to be confident that it is fast
enough.


Maybe we should use specific_build_type_timeout() to set a different timeout for slow build
types.

E.g.
specific_build_type_timeout(2, slow_build_timeout=5)



-- 
To view, visit http://gerrit.cloudera.org:8080/8713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0bff485a872df7be8efd784314a6ca91aaadd11
Gerrit-Change-Number: 8713
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Dec 2017 17:40:46 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message