Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EFC11200D45 for ; Thu, 9 Nov 2017 01:24:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EE50C160C01; Thu, 9 Nov 2017 00:24:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 42A3A160BDA for ; Thu, 9 Nov 2017 01:24:57 +0100 (CET) Received: (qmail 18066 invoked by uid 500); 9 Nov 2017 00:24:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 18051 invoked by uid 99); 9 Nov 2017 00:24:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 00:24:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 70A771A364F for ; Thu, 9 Nov 2017 00:24:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WLwDGpWh0_Yo for ; Thu, 9 Nov 2017 00:24:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id DD5895FAF9 for ; Thu, 9 Nov 2017 00:24:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA90OqDd025504; Thu, 9 Nov 2017 00:24:52 GMT X-Gerrit-PatchSet: 1 Date: Thu, 9 Nov 2017 00:24:52 +0000 From: "Kim Jin Chul (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5237=3A_support_custom_string_in_date/time_format=0A?= X-Gerrit-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 X-Gerrit-Change-Number: 8508 X-Gerrit-ChangeURL: X-Gerrit-Commit: ee9889d038391443c6459f5f57ae44beac548c17 Reply-To: jinchul@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="8JCHWvm7F+U="; charset=UTF-8 archived-at: Thu, 09 Nov 2017 00:24:58 -0000 --8JCHWvm7F+U= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Kim Jin Chul has uploaded this change for review=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8508 Change subject: IMPALA-5237: support custom string in= date/time format =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E IMPALA-5237: support custom string in date/time format Impala does no= t represent a custom string at date/time format=2E For example, addtional c= ustom string between the patterns(e=2Eg=2E HH\'H\' =3D> 11H) Hive supports = this feature, so user wants to get a same result from Impala=2E By the way,= Impala returns a different result as below=2E * Hive > select from_unixti= me(1492677564, 'HH\'H\' mm\'M\' ss\'S\''); 08H 39M 24S * Impala > select f= rom_unixtime(1492677564, 'HH\'H\' mm\'M\' ss\'S\''); 08'8' 39'4' 24'0' The= change affects the format pattern for from_unixtime/from_timestamp=2E The= re is one intentional difference between Hive and Impala=2E In Impala, the = format string should have any date or time patten as below=2E * Hive > sel= ect from_unixtime(0, '\'Hello world!\''); Hello world! * Impala > select f= rom_unixtime(0, '\'Hello world!\''); Bad date/time conversion format: 'Hell= o world!' Testing: Add unit tests for working and nonworking cases Change= -Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 --- M be/src/exprs/expr-test= =2Ecc M be/src/runtime/timestamp-parse-util=2Ecc 2 files changed, 28 insert= ions(+), 0 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/I= mpala-ASF refs/changes/08/8508/1 -- To view, visit http://gerrit=2Eclouder= a=2Eorg:8080/8508 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080= /settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageT= ype: newchange Gerrit-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 = Gerrit-Change-Number: 8508 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul --8JCHWvm7F+U=--