Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 70F70200D4C for ; Thu, 30 Nov 2017 23:03:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6F745160C01; Thu, 30 Nov 2017 22:03:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B54B9160BF6 for ; Thu, 30 Nov 2017 23:03:56 +0100 (CET) Received: (qmail 1917 invoked by uid 500); 30 Nov 2017 22:03:56 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 1906 invoked by uid 99); 30 Nov 2017 22:03:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2017 22:03:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 429821A0880 for ; Thu, 30 Nov 2017 22:03:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4qiDt-WE7XOt for ; Thu, 30 Nov 2017 22:03:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E342B5F588 for ; Thu, 30 Nov 2017 22:03:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAUM3pw2009918; Thu, 30 Nov 2017 22:03:51 GMT Message-Id: <201711302203.vAUM3pw2009918@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Thu, 30 Nov 2017 22:03:50 +0000 From: "Taras Bobrovytsky (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Michael Ho , Zach Amsden , John Sherman , Dan Hecht X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5017=3A_Error_on_decimal_overflow=0A?= X-Gerrit-Change-Id: Id98a92c9a9469ec8cf14e518c741a2dab7053019 X-Gerrit-Change-Number: 8404 X-Gerrit-ChangeURL: X-Gerrit-Commit: 51b56238efb70cd4082ceb0045e2efb5906b9900 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 30 Nov 2017 22:03:50 +0000 Reply-To: tbobrovytsky@cloudera.com, zamsden@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, kwho@cloudera.com, dhecht@cloudera.com, jfs@arcadiadata.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="36P/Lyw7fYc="; charset=UTF-8 archived-at: Thu, 30 Nov 2017 22:03:57 -0000 --36P/Lyw7fYc= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Taras Bobrovytsky has posted comments on this change=2E ( http://gerrit=2Ec= loudera=2Eorg:8080/8404 ) Change subject: IMPALA-5017: Error on decimal ov= erflow =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Pat= ch Set 2: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8404/2/be/s= rc/exprs/aggregate-functions-ir=2Ecc File be/src/exprs/aggregate-functions-= ir=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8404/2/be/src/exprs/aggre= gate-functions-ir=2Ecc@429 PS2, Line 429: } > how many bits does it t= ake to represent 10^38 - 1? if 126 or less, then it Unfortunately we need = 127 bits to represent 10^38 - 1=2E Fixed the other cases=2E -- To view,= visit http://gerrit=2Ecloudera=2Eorg:8080/8404 To unsubscribe, visit http:= //gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-= Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id98a92c9a9469= ec8cf14e518c741a2dab7053019 Gerrit-Change-Number: 8404 Gerrit-PatchSet: 2 G= errit-Owner: Taras Bobrovytsky Gerrit-Reviewe= r: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins= Gerrit-Reviewer: John Sherman Gerrit-Reviewer: Mic= hael Ho Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden Gerrit-Comment-Da= te: Thu, 30 Nov 2017 22:03:50 +0000 Gerrit-HasComments: Yes --36P/Lyw7fYc=--