Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 66C39200D4A for ; Tue, 28 Nov 2017 23:30:41 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 65385160C07; Tue, 28 Nov 2017 22:30:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8385F160BE7 for ; Tue, 28 Nov 2017 23:30:40 +0100 (CET) Received: (qmail 5728 invoked by uid 500); 28 Nov 2017 22:30:39 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 5698 invoked by uid 99); 28 Nov 2017 22:30:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2017 22:30:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A5A1EC4FDE for ; Tue, 28 Nov 2017 22:30:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KB_WAM_FROM_NAME_SINGLEWORD=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id m1KRm_22f4JG for ; Tue, 28 Nov 2017 22:30:37 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 225F15F520 for ; Tue, 28 Nov 2017 22:30:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vASMUZvA017482; Tue, 28 Nov 2017 22:30:35 GMT Message-Id: <201711282230.vASMUZvA017482@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 1 Date: Tue, 28 Nov 2017 22:30:35 +0000 From: "Dan Hecht (Code Review)" To: Sailesh Mukil , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5054=3A_=5BSECURITY=5D_Enable_KRPC_w/_TLS_in_Impala=0A?= X-Gerrit-Change-Id: I9a14a44fdea9ab668f3714eb69fdb188bce38f5a X-Gerrit-Change-Number: 8439 X-Gerrit-ChangeURL: X-Gerrit-Commit: d603f041eb09c98fb97d9cc4f315e9bfa20a52f7 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 28 Nov 2017 22:30:35 +0000 Reply-To: dhecht@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="SffGLSFJwZU="; charset=UTF-8 archived-at: Tue, 28 Nov 2017 22:30:41 -0000 --SffGLSFJwZU= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dan Hecht has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ = TLS in Impala =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 1: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8439/= 1/be/src/rpc/rpc-mgr=2Eh File be/src/rpc/rpc-mgr=2Eh: http://gerrit=2Eclou= dera=2Eorg:8080/#/c/8439/1/be/src/rpc/rpc-mgr=2Eh@183 PS1, Line 183: /// T= he following strings preserve the Kudu flags original values to restore in = : /// Shutdown() as they will be modified by us=2E = : string flag_save_ca_certificate_file; : string flag_= save_rpc_private_key_file; : string flag_save_rpc_certificat= e_file; : string flag_save_rpc_private_key_password_cmd; = : string flag_save_rpc_tls_ciphers; : string fla= g_save_rpc_tls_min_protocol; > Ah you're right=2E I assumed that would have= been called through some code pa Please add a test case too=2E -- To v= iew, visit http://gerrit=2Ecloudera=2Eorg:8080/8439 To unsubscribe, visit h= ttp://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Ger= rit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a14a44fd= ea9ab668f3714eb69fdb188bce38f5a Gerrit-Change-Number: 8439 Gerrit-PatchSet:= 1 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Da= n Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comm= ent-Date: Tue, 28 Nov 2017 22:30:35 +0000 Gerrit-HasComments: Yes --SffGLSFJwZU=--