Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9DBF9200D51 for ; Thu, 23 Nov 2017 01:02:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9C25E160C0F; Thu, 23 Nov 2017 00:02:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E28D6160BFD for ; Thu, 23 Nov 2017 01:02:58 +0100 (CET) Received: (qmail 51142 invoked by uid 500); 23 Nov 2017 00:02:58 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 51131 invoked by uid 99); 23 Nov 2017 00:02:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Nov 2017 00:02:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 252651805BF for ; Thu, 23 Nov 2017 00:02:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Yp16G6SgiXKE for ; Thu, 23 Nov 2017 00:02:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6CC115FB35 for ; Thu, 23 Nov 2017 00:02:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAN02rOF013357; Thu, 23 Nov 2017 00:02:53 GMT Message-Id: <201711230002.vAN02rOF013357@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Thu, 23 Nov 2017 00:02:53 +0000 From: "Bharath Vissapragada (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5310=3A_Part_2=3A_Add_SAMPLED_NDV=28=29_function=2E=0A?= X-Gerrit-Change-Id: Ia51d56ee67ec6073e92f90bebb4005484138b820 X-Gerrit-Change-Number: 8569 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1b2b50a9ca0fa11088ced9309ae7d61ea65fc180 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 23 Nov 2017 00:02:53 +0000 Reply-To: bharathv@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="qn68gzrP+T0="; charset=UTF-8 archived-at: Thu, 23 Nov 2017 00:02:59 -0000 --qn68gzrP+T0= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bharath Vissapragada has posted comments on this change=2E ( http://gerrit= =2Ecloudera=2Eorg:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAM= PLED_NDV() function=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E Patch Set 2: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080= /#/c/8569/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest=2E= java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest=2Eja= va: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8569/2/fe/src/test/java/org/ap= ache/impala/analysis/AnalyzeStmtsTest=2Ejava@2063 PS2, Line 2063: 0=2E0 Won= dering if 0=2E0 is a valid sample %=2E What do we scan in that case? Do we = assign some default ndvs? http://gerrit=2Ecloudera=2Eorg:8080/#/c/8569/2/= fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest=2Ejava@2066 PS= 2, Line 2066: for (Column col: allScalarTypes=2EgetColumns()) { -ve t= est cases on non scalar columns, just for completeness? -- To view, vis= it http://gerrit=2Ecloudera=2Eorg:8080/8569 To unsubscribe, visit http://ge= rrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Bran= ch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia51d56ee67ec6073e= 92f90bebb4005484138b820 Gerrit-Change-Number: 8569 Gerrit-PatchSet: 2 Gerri= t-Owner: Alex Behm Gerrit-Reviewer: Alex Behm = Gerrit-Reviewer: Bharath Vissapragada Gerrit-Comment-Date: Thu, 23 Nov 2017 00:02:53 +0000 Gerr= it-HasComments: Yes --qn68gzrP+T0=--