Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A42B200D4F for ; Wed, 22 Nov 2017 06:49:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 08C83160C0E; Wed, 22 Nov 2017 05:49:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4E79F160BFC for ; Wed, 22 Nov 2017 06:49:01 +0100 (CET) Received: (qmail 84031 invoked by uid 500); 22 Nov 2017 05:49:00 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 84020 invoked by uid 99); 22 Nov 2017 05:49:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Nov 2017 05:49:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C9628CB1EC for ; Wed, 22 Nov 2017 05:48:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KB_WAM_FROM_NAME_SINGLEWORD=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lkN2wihk9TE6 for ; Wed, 22 Nov 2017 05:48:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 830395FB35 for ; Wed, 22 Nov 2017 05:48:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAM5mtW3025484; Wed, 22 Nov 2017 05:48:55 GMT Message-Id: <201711220548.vAM5mtW3025484@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Wed, 22 Nov 2017 05:48:55 +0000 From: "Kim Jin Chul (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2250=3A_Make_multiple_COUNT=28DISTINCT=29_message_state_workarounds=0A?= X-Gerrit-Change-Id: I5084be10946d68f3ec0760c2b7e698635df26a89 X-Gerrit-Change-Number: 8614 X-Gerrit-ChangeURL: X-Gerrit-Commit: eb4678a8936145f397734861bab831f9a147f100 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 22 Nov 2017 05:48:55 +0000 Reply-To: jinchul@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="hErHGAqb/9Q="; charset=UTF-8 archived-at: Wed, 22 Nov 2017 05:49:02 -0000 --hErHGAqb/9Q= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Kim Jin Chul has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8614 ) Change subject: IMPALA-2250: Make multiple COUNT(DIST= INCT) message state workarounds =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 3: (1 comment) http://gerrit=2Ecloudera=2E= org:8080/#/c/8614/3/fe/src/main/java/org/apache/impala/analysis/AggregateIn= fo=2Ejava File fe/src/main/java/org/apache/impala/analysis/AggregateInfo=2E= java: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8614/3/fe/src/main/java/org/= apache/impala/analysis/AggregateInfo=2Ejava@249 PS3, Line 249: if (= distinctAggExprs=2Eget(i)=2EgetFnName()=2EgetFunction()=2EequalsIgnoreCase(= : "count")) { > That's correct, but that error me= ssage is also thrown for non-count(distinc 1=2E Do you mean the guidance of= NDV is also printed on your example? Why should we do this? If a given que= ry does not have any use case of COUNT(DISTINCT), we don't have to display= this=2E It could make an user confuse=2E May I know your intention why we = should include this? -- To view, visit http://gerrit=2Ecloudera=2Eorg:8= 080/8614 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings= Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comm= ent Gerrit-Change-Id: I5084be10946d68f3ec0760c2b7e698635df26a89 Gerrit-Chan= ge-Number: 8614 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul Gerrit-Reviewer: Alex Behm Gerrit-Rev= iewer: Kim Jin Chul Gerrit-Comment-Date: Wed, 22 Nov = 2017 05:48:55 +0000 Gerrit-HasComments: Yes --hErHGAqb/9Q=--