Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711212018.vALKIMwF030055@ip-10-146-233-104.ec2.internal>
Date: Tue, 21 Nov 2017 20:18:22 +0000
From: "Zoram Thanga (Code Review)" <gerrit@cloudera.org>
To: Zoram Thanga <zoram@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Michael Ho <kwho@cloudera.com>,
        Philip Zeyliger <philip@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6225=3A_Query_profile_date-time_strings_should_have_ns_precision=2E=0A?=
In-Reply-To: <gerrit.1511218931000.I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0@gerrit.cloudera.org>
References: <gerrit.1511218931000.I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0@gerrit.cloudera.org>
Reply-To: zoram@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com,
        dhecht@cloudera.com, kwho@cloudera.com, zoram@cloudera.com,
        philip@cloudera.com, reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="Z2rXwSZfOR0="; charset=UTF-8
archived-at: Tue, 21 Nov 2017 20:18:28 -0000

--Z2rXwSZfOR0=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Zoram Thanga has posted comments on this change=2E ( http://gerrit=2Ecloude=
ra=2Eorg:8080/8611 )

Change subject: IMPALA-6225: Query profile date-time =
strings should have ns precision=2E
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E


Patch Set 3:

> > (2 comments)
 > >
 > > > (1 comme=
nt)
 > > >
 > > > Please add a test as Phil suggested=2E If we decide to ad=
d 64-bit
 > > > timestamps to the profile, please file a JIRA for it=2E
 > =
>
 > > Alas, I haven't yet found a quick way to add the test=2E How does
 >=
 one
 > > get a query id from a query handle/result (returned by
 > > execu=
te_query_async/execute_query)? If I know the query id, that
 > > can be pas=
sed to read_profile_page from where we can extract the
 > > fields of inter=
est=2E
 > 
 > =2E/experiments/test_process_failures=2Epy and =2E/webserver/=
test_web_pages=2Epy
 > looks like they have examples for beeswax and operat=
ion_id_to_query_id()
 > looks like for HS2=2E

Thanks Dan! Have added a new=
 test case that checks nanosecond-precision start and end date-time stamps=
=2E


-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8611
To unsubs=
cribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: =
Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-=
Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0
Gerrit-Change-Number: 8611
Ge=
rrit-PatchSet: 3
Gerrit-Owner: Zoram Thanga <zoram@cloudera=2Ecom>
Gerrit-R=
eviewer: Dan Hecht <dhecht@cloudera=2Ecom>
Gerrit-Reviewer: Michael Ho <kwh=
o@cloudera=2Ecom>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera=2Ecom>
=
Gerrit-Reviewer: Zoram Thanga <zoram@cloudera=2Ecom>
Gerrit-Comment-Date: T=
ue, 21 Nov 2017 20:18:22 +0000
Gerrit-HasComments: No

--Z2rXwSZfOR0=--