Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5FAB1200D53 for ; Tue, 21 Nov 2017 05:40:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5E1AB160C0D; Tue, 21 Nov 2017 04:40:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A2F7A160BF9 for ; Tue, 21 Nov 2017 05:40:09 +0100 (CET) Received: (qmail 23490 invoked by uid 500); 21 Nov 2017 04:40:08 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 23479 invoked by uid 99); 21 Nov 2017 04:40:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 04:40:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A697DC357C for ; Tue, 21 Nov 2017 04:40:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KB_WAM_FROM_NAME_SINGLEWORD=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EkjZZjHZB6Eg for ; Tue, 21 Nov 2017 04:40:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 590D75FD71 for ; Tue, 21 Nov 2017 04:40:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAL4e5OS006088; Tue, 21 Nov 2017 04:40:05 GMT Message-Id: <201711210440.vAL4e5OS006088@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 10 Date: Tue, 21 Nov 2017 04:40:05 +0000 From: "Impala Public Jenkins (Code Review)" To: Csaba Ringhofer , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6054=3A_Parquet_dictionary_pages_should_be_freed_on_dictionary_construction=0A?= X-Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004 X-Gerrit-Change-Number: 8436 X-Gerrit-ChangeURL: X-Gerrit-Commit: 27c43fed0ec05cbcddd9225fd4a194b1cfd0704b In-Reply-To: References: Reply-To: impala-cr@cloudera.com, csringhofer@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="v7DQ54/WUWs="; charset=UTF-8 archived-at: Tue, 21 Nov 2017 04:40:10 -0000 --v7DQ54/WUWs= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8436 ) Change subject: IMPALA-6054: Parque= t dictionary pages should be freed on dictionary construction =2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-6054: Parquet dict= ionary pages should be freed on dictionary construction During dictionary = constructon, most types are copied from the parquet dictionary page, but St= ringValues keep pointers to it=2E In this case, the dictionary page must be= kept and attached to the last row batch that references it=2E In case of o= ther types, it is safe do delete the dictionary page after the construction= of the dictionary=2E This patch contains two optimizations: - dictionary = pages are deleted as soon as possible for non string types - in non-compres= sed and non-string case, an unnecessary copy is avoided Change-Id: I4d9d5f= 4da1028d961155dafdac0028a1c3641004 Reviewed-on: http://gerrit=2Ecloudera=2E= org:8080/8436 Reviewed-by: Tim Armstrong Tested= -by: Impala Public Jenkins --- M be/src/exec/parquet-column-readers=2Ecc 1 = file changed, 33 insertions(+), 18 deletions(-) Approvals: Tim Armstrong= : Looks good to me, approved Impala Public Jenkins: Verified -- To view= , visit http://gerrit=2Ecloudera=2Eorg:8080/8436 To unsubscribe, visit http= ://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit= -Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4d9d5f4da1028= d961155dafdac0028a1c3641004 Gerrit-Change-Number: 8436 Gerrit-PatchSet: 10 = Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer:= Csaba Ringhofer Gerrit-Reviewer: Impala Publi= c Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer:= Tim Armstrong --v7DQ54/WUWs=--