Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711180022.vAI0MOFM018513@ip-10-146-233-104.ec2.internal>
Date: Sat, 18 Nov 2017 00:22:24 +0000
From: "Gabor Kaszab (Code Review)" <gerrit@cloudera.org>
To: Lars Volker <lv@cloudera.com>, Laszlo Gaal <laszlo.gaal@cloudera.com>,
        Michael Brown <mikeb@cloudera.com>,
        Zoltan Borok-Nagy <boroknagyz@cloudera.com>,
        Philip Zeyliger <philip@cloudera.com>,
        David Knupp <dknupp@cloudera.com>, Attila Jeges <attilaj@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>,
        Csaba Ringhofer <csringhofer@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1144=3A_Fix_exception_when_cancelling_query_in_Impala-shell_with_CTRL-C=0A?=
In-Reply-To: <gerrit.1510704837000.I6cefaf1dae78baae238289816a7cb9d210fb38e2@gerrit.cloudera.org>
References: <gerrit.1510704837000.I6cefaf1dae78baae238289816a7cb9d210fb38e2@gerrit.cloudera.org>
Reply-To: gaborkaszab@cloudera.com, dknupp@cloudera.com, philip@cloudera.com,
        reviews@impala.incubator.apache.org, mikeb@cloudera.com,
        impala-cr@cloudera.com, boroknagyz@cloudera.com, lv@cloudera.com,
        marcelk@gmail.com, tarmstrong@cloudera.com, laszlo.gaal@cloudera.com,
        csringhofer@cloudera.com, attilaj@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="AY2n+IuBEcM="; charset=UTF-8
archived-at: Sat, 18 Nov 2017 00:22:30 -0000

--AY2n+IuBEcM=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Ze=
yliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, 

I'd li=
ke you to reexamine a change=2E Please visit

    http://gerrit=2Ecloudera=
=2Eorg:8080/8549

to look at the new patch set (#5)=2E

Change subject: IMP=
ALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C
=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPALA-1144: =
Fix exception when cancelling query in Impala-shell with CTRL-C

Issue1: Wh=
en query is cancelled via CTRL-C while being executed in Impala-shell
then =
an exception is thrown from Impala backend saying 'Invalid query handle'=2E=

This is because one ImpalaClient was making RPC's while another ImpalaClie=
nt
cancelled the query on the backend=2E As a result RPC handlers in Impala=
Server
try to access a ClientRequestState that had been cleared from the ba=
ckend=2E The
issue is confidently reproducable both in wait_to_finish and i=
n fetch states of
the query=2E

As a solution the query cancellation is ind=
icated to ImpalaClient via a bool
flag=2E Once a cancellation originated ex=
ception reaches Impala shell this flag
is checked to decide whether to supp=
ress the error or not=2E

Issue2: Every time a query was cancelled a 'use d=
b' command was issued
automatically=2E This happened to historical reasons =
but is not needed anymore
(see Jira for more details)=2E

Change-Id: I6cefa=
f1dae78baae238289816a7cb9d210fb38e2
---
M shell/impala_client=2Epy
M shell/=
impala_shell=2Epy
M tests/shell/test_shell_commandline=2Epy
3 files changed=
, 54 insertions(+), 6 deletions(-)


  git pull ssh://gerrit=2Ecloudera=2Eo=
rg:29418/Impala-ASF refs/changes/49/8549/5
-- 
To view, visit http://gerrit=
=2Ecloudera=2Eorg:8080/8549
To unsubscribe, visit http://gerrit=2Ecloudera=
=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerr=
it-MessageType: newpatchset
Gerrit-Change-Id: I6cefaf1dae78baae238289816a7c=
b9d210fb38e2
Gerrit-Change-Number: 8549
Gerrit-PatchSet: 5
Gerrit-Owner: Ga=
bor Kaszab <gaborkaszab@cloudera=2Ecom>
Gerrit-Reviewer: Attila Jeges <atti=
laj@cloudera=2Ecom>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera=
=2Ecom>
Gerrit-Reviewer: David Knupp <dknupp@cloudera=2Ecom>
Gerrit-Reviewe=
r: Gabor Kaszab <gaborkaszab@cloudera=2Ecom>
Gerrit-Reviewer: Lars Volker <=
lv@cloudera=2Ecom>
Gerrit-Reviewer: Laszlo Gaal <laszlo=2Egaal@cloudera=2Ec=
om>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera=2Ecom>
Gerrit-Reviewer: =
Philip Zeyliger <philip@cloudera=2Ecom>
Gerrit-Reviewer: Tim Armstrong <tar=
mstrong@cloudera=2Ecom>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@clou=
dera=2Ecom>

--AY2n+IuBEcM=--