Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711160620.vAG6KR5B017421@ip-10-146-233-104.ec2.internal>
Date: Thu, 16 Nov 2017 06:20:27 +0000
From: "anujphadke (Code Review)" <gerrit@cloudera.org>
To: anujphadke <aphadke@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Michael Brown <mikeb@cloudera.com>,
        Dan Hecht <dhecht@cloudera.com>,
        Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4848=3A_Add_WIDTH_BUCKET=28=29_function=0A?=
In-Reply-To: <gerrit.1487202122000.I081bc916b1bef7b929ca161a9aade3b54c6b858f@gerrit.cloudera.org>
References: <gerrit.1487202122000.I081bc916b1bef7b929ca161a9aade3b54c6b858f@gerrit.cloudera.org>
Reply-To: aphadke@cloudera.com, impala-cr@cloudera.com, aphadke@cloudera.com,
        marcelk@gmail.com, dhecht@cloudera.com, tbobrovytsky@cloudera.com,
        alex.behm@cloudera.com, reviews@impala.incubator.apache.org,
        mikeb@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="cYYn0A13UvE="; charset=UTF-8
archived-at: Thu, 16 Nov 2017 06:20:33 -0000

--cYYn0A13UvE=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

anujphadke has posted comments on this change=2E ( http://gerrit=2Ecloudera=
=2Eorg:8080/6023 )

Change subject: IMPALA-4848: Add WIDTH_BUCKET() functio=
n
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E


Patch Set=
 7:

(4 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#/c/6023/7/be/src/ex=
prs/math-functions-ir=2Ecc
File be/src/exprs/math-functions-ir=2Ecc:

http:=
//gerrit=2Ecloudera=2Eorg:8080/#/c/6023/7/be/src/exprs/math-functions-ir=2E=
cc@429
PS7, Line 429: bucket_width
> Done
Please ignore my last comment=2E =
Accidentally got posted when replying to Dan's comment=2E I still havn't up=
loaded my latest patch=2E


http://gerrit=2Ecloudera=2Eorg:8080/#/c/6023/7/=
be/src/exprs/math-functions-ir=2Ecc@431
PS7, Line 431: width_size
> Done
Pl=
ease ignore my last comment=2E Accidentally got posted when replying to Dan=
's comment=2E I still havn't uploaded my latest patch=2E


http://gerrit=2E=
cloudera=2Eorg:8080/#/c/6023/7/be/src/exprs/math-functions-ir=2Ecc@479
PS7,=
 Line 479:     result=2Eval =3D num_buckets=2Eval;
> Done
Please ignore my =
last comment=2E Accidentally got posted when replying to Dan's comment=2E I=
 still haven't uploaded my latest patch=2E


http://gerrit=2Ecloudera=2Eorg=
:8080/#/c/6023/7/be/src/exprs/math-functions-ir=2Ecc@516
PS7, Line 516:   i=
nt256_t x =3D ConvertToInt256(buckets=2Evalue()) * ConvertToInt256(width_si=
ze=2Evalue());
> This patch stores intermediate results in int256_t only wh=
en needed=2E Uses i
Please ignore my last comment=2E Accidentally got poste=
d when replying to Dan's comment=2E I still havn't uploaded my latest patch=
=2E


-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/6023
To unsub=
scribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project:=
 Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change=
-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f
Gerrit-Change-Number: 6023
G=
errit-PatchSet: 7
Gerrit-Owner: anujphadke <aphadke@cloudera=2Ecom>
Gerrit-=
Reviewer: Alex Behm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: Dan Hecht=
 <dhecht@cloudera=2Ecom>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera=2Ec=
om>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera=2Ecom>
Gerrit=
-Reviewer: anujphadke <aphadke@cloudera=2Ecom>
Gerrit-Comment-Date: Thu, 16=
 Nov 2017 06:20:27 +0000
Gerrit-HasComments: Yes

--cYYn0A13UvE=--