Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711142351.vAENpa1P008348@ip-10-146-233-104.ec2.internal>
Date: Tue, 14 Nov 2017 23:51:36 +0000
From: "Kim Jin Chul (Code Review)" <gerrit@cloudera.org>
To: Attila Jeges <attilaj@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5237=3A_Support_a_quoted_string_in_date/time_format=0A?=
In-Reply-To: <gerrit.1510187092000.Ie34055ac695748bcfb110bfa6ed5308f469ea178@gerrit.cloudera.org>
References: <gerrit.1510187092000.Ie34055ac695748bcfb110bfa6ed5308f469ea178@gerrit.cloudera.org>
Reply-To: jinchul@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com,
        tarmstrong@cloudera.com, attilaj@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="sjimHJGpJWA="; charset=UTF-8
archived-at: Tue, 14 Nov 2017 23:51:41 -0000

--sjimHJGpJWA=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Attila Jeges, Tim Armstrong, 

I'd like you to reexamine a change=2E =
Please visit

    http://gerrit=2Ecloudera=2Eorg:8080/8508

to look at the =
new patch set (#3)=2E

Change subject: IMPALA-5237: Support a quoted string=
 in date/time format
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E

IMPALA-5237: Support a quoted string in date/time format

Impala do=
es not represent a quoted string at date/time format=2E
For example, addtio=
nal quoted string between the patterns
(e=2Eg=2E HH\'H\' =3D> 11H)=2E Hive =
supports this feature, so user wants
to get a same result from Impala=2E By=
 the way, Impala returns
a different result as below=2E

* Hive
> select fr=
om_unixtime(1492677564, 'HH\'H\' mm\'M\' ss\'S\'');
08H 39M 24S

* Impala
>=
 select from_unixtime(1492677564, 'HH\'H\' mm\'M\' ss\'S\'');
08'8' 39'4' 2=
4'0'

The change affects the format pattern for
from_unixtime/from_timestam=
p/unix_timestamp=2E

In unix_timestamp, user can also specify a quoted stri=
ng like this=2E

> select unix_timestamp('\'Epoch time: \'19700101',
> '\'E=
poch time: \'yyyyMMdd');
0

By the way, the quoted strings between input an=
d format should be
exactly same and internally string comparison is case-se=
nsitive=2E

There is one intentional difference between Hive and Impala=2E
=
In Impala, the format string should have any date or time patten
as below=
=2E Throwing the error/warning is better if Impala cannot
optimize the expr=
ession=2E User must rewrite the query and don't pay
the function call=2E

*=
 Hive
> select from_unixtime(0, '\'Hello world!\'');
Hello world!

* Impala=

> select from_unixtime(0, '\'Hello world!\'');
Bad date/time conversion fo=
rmat: 'Hello world!'

Testing:
Add unit tests for working and nonworking ca=
ses

Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178
---
M be/src/expr=
s/expr-test=2Ecc
M be/src/runtime/timestamp-parse-util=2Ecc
M be/src/runtim=
e/timestamp-parse-util=2Eh
3 files changed, 92 insertions(+), 2 deletions(-=
)


  git pull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/=
08/8508/3
-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8508
To un=
subscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Proje=
ct: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit=
-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178
Gerrit-Change-Number:=
 8508
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul <jinchul@gmail=2Ecom>
G=
errit-Reviewer: Attila Jeges <attilaj@cloudera=2Ecom>
Gerrit-Reviewer: Kim =
Jin Chul <jinchul@gmail=2Ecom>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@c=
loudera=2Ecom>

--sjimHJGpJWA=--