Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 527BD200D48 for ; Wed, 15 Nov 2017 00:28:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 50D4F160C07; Tue, 14 Nov 2017 23:28:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 983AC160BF4 for ; Wed, 15 Nov 2017 00:28:00 +0100 (CET) Received: (qmail 74147 invoked by uid 500); 14 Nov 2017 23:27:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74136 invoked by uid 99); 14 Nov 2017 23:27:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 23:27:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B8D02C250A for ; Tue, 14 Nov 2017 23:27:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GEcrFIUsyOwl for ; Tue, 14 Nov 2017 23:27:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3971060CF1 for ; Tue, 14 Nov 2017 23:27:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAENRtPp006870; Tue, 14 Nov 2017 23:27:55 GMT Message-Id: <201711142327.vAENRtPp006870@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Tue, 14 Nov 2017 23:27:55 +0000 From: "Zoltan Borok-Nagy (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Philip Zeyliger X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2235=3A_Fix_current_db_when_shell_auto-reconnects=0A?= X-Gerrit-Change-Id: I40dfa00ba0314d356fe8617446f516505c925e5e X-Gerrit-Change-Number: 8368 X-Gerrit-ChangeURL: X-Gerrit-Commit: e7ad06546422e60b25cb00cc783358aeccc3348b In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 14 Nov 2017 23:27:55 +0000 Reply-To: boroknagyz@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, philip@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="uSByX/ni7EQ="; charset=UTF-8 archived-at: Tue, 14 Nov 2017 23:28:01 -0000 --uSByX/ni7EQ= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Zoltan Borok-Nagy has posted comments on this change=2E ( http://gerrit=2Ec= loudera=2Eorg:8080/8368 ) Change subject: IMPALA-2235: Fix current db when= shell auto-reconnects =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E Patch Set 5: (1 comment) Thanks for the review http://gerrit= =2Ecloudera=2Eorg:8080/#/c/8368/4/tests/custom_cluster/test_shell_interacti= ve_reconnect=2Epy File tests/custom_cluster/test_shell_interactive_reconnec= t=2Epy: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8368/4/tests/custom_cluste= r/test_shell_interactive_reconnect=2Epy@60 PS4, Line 60: start_num_quer= ies =3D impalad=2Eget_metric_value(NUM_QUERIES) > Would "p=2Esend_cmd("show= tables"); p=2Eget_result()" make this stable, without Yeah I also felt wro= ng about the sleep for the same reason, but didn't know any better=2E Unfo= rtunately get_result() closes STDIN and that exits the Impala shell process= =2E But, looking at other test codes I figured out how I can use the Impal= adService class to wait for my USE command=2E -- To view, visit http://= gerrit=2Ecloudera=2Eorg:8080/8368 To unsubscribe, visit http://gerrit=2Eclo= udera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master= Gerrit-MessageType: comment Gerrit-Change-Id: I40dfa00ba0314d356fe8617446f= 516505c925e5e Gerrit-Change-Number: 8368 Gerrit-PatchSet: 5 Gerrit-Owner: Z= oltan Borok-Nagy Gerrit-Reviewer: Philip Zeylig= er Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy G= errit-Comment-Date: Tue, 14 Nov 2017 23:27:55 +0000 Gerrit-HasComments: Yes= --uSByX/ni7EQ=--