Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3A3D200D3C for ; Tue, 14 Nov 2017 23:27:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F1ED0160BF4; Tue, 14 Nov 2017 22:27:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 42CF7160BD7 for ; Tue, 14 Nov 2017 23:27:57 +0100 (CET) Received: (qmail 24042 invoked by uid 500); 14 Nov 2017 22:27:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 24027 invoked by uid 99); 14 Nov 2017 22:27:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 22:27:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 769091A02DB for ; Tue, 14 Nov 2017 22:27:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Xkgyy9O96VPy for ; Tue, 14 Nov 2017 22:27:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 600AC5F568 for ; Tue, 14 Nov 2017 22:27:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAEMRom9005461; Tue, 14 Nov 2017 22:27:50 GMT Message-Id: <201711142227.vAEMRom9005461@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 12 Date: Tue, 14 Nov 2017 22:27:50 +0000 From: "Kim Jin Chul (Code Review)" To: Jim Apple , Attila Jeges , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5754=3A_Improve_randomness_of_rand=28=29/random=28=29=0A?= X-Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 X-Gerrit-Change-Number: 8355 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8ac7314a33e577d676260611b434c9391bbc494f In-Reply-To: References: Reply-To: jinchul@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com, jbapple-impala@apache.org, attilaj@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="B/cH3fvv2MM="; charset=UTF-8 archived-at: Tue, 14 Nov 2017 22:27:58 -0000 --B/cH3fvv2MM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change=2E Plea= se visit http://gerrit=2Ecloudera=2Eorg:8080/8355 to look at the new = patch set (#12)=2E Change subject: IMPALA-5754: Improve randomness of rand= ()/random() =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E I= MPALA-5754: Improve randomness of rand()/random() Currently implementation= of rand/random built-in functions use rand_r of C library=2E We recognized= its randomness was poor=2E std::mt19937 in the C++11 standard library show= s better randomness than rand_r=2E Testing: Revise unit test in expr-test = Add E2E test to random=2Etest Change-Id: Idafdd5fe7502ff242c76a91a815c5651= 46108684 --- M be/src/exprs/expr-test=2Ecc M be/src/exprs/math-functions-ir= =2Ecc A testdata/workloads/functional-query/queries/QueryTest/random=2Etest= M tests/query_test/test_queries=2Epy 4 files changed, 61 insertions(+), 30= deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF r= efs/changes/55/8355/12 -- To view, visit http://gerrit=2Ecloudera=2Eorg:80= 80/8355 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings = Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpa= tchset Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-C= hange-Number: 8355 Gerrit-PatchSet: 12 Gerrit-Owner: Kim Jin Chul Gerrit-Reviewer: Attila Jeges Gerrit-= Reviewer: Jim Apple Gerrit-Reviewer: Kim Jin = Chul --B/cH3fvv2MM=--