Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0372E200D3D for ; Mon, 13 Nov 2017 23:45:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 01F69160BF3; Mon, 13 Nov 2017 22:45:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47C81160BF0 for ; Mon, 13 Nov 2017 23:45:06 +0100 (CET) Received: (qmail 21423 invoked by uid 500); 13 Nov 2017 22:45:05 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 21169 invoked by uid 99); 13 Nov 2017 22:45:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Nov 2017 22:45:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6B5841A0B79 for ; Mon, 13 Nov 2017 22:45:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 44tJmXYh-ZE7 for ; Mon, 13 Nov 2017 22:45:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2BCFB5F640 for ; Mon, 13 Nov 2017 22:45:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vADMixis011338; Mon, 13 Nov 2017 22:44:59 GMT Message-Id: <201711132244.vADMixis011338@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 1 Date: Mon, 13 Nov 2017 22:44:59 +0000 From: "Zach Amsden (Code Review)" To: Philip Zeyliger , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Jim Apple , Michael Brown , Joe McDonnell X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Pin_gen_build_version=27s_git_handling_to_typical_git_dir=2E=0A?= X-Gerrit-Change-Id: I98870a1cb2073ddcf9ba1620e3801e1964930edd X-Gerrit-Change-Number: 8500 X-Gerrit-ChangeURL: X-Gerrit-Commit: ff8023f9b526e438ae1411cf4de61a64e803a45a In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 13 Nov 2017 22:44:59 +0000 Reply-To: zamsden@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com, marcelk@gmail.com, joemcdonnell@cloudera.com, philip@cloudera.com, jbapple-impala@apache.org, reviews@impala.incubator.apache.org, mikeb@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="GoASatyFv+4="; charset=UTF-8 archived-at: Mon, 13 Nov 2017 22:45:07 -0000 --GoASatyFv+4= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Zach Amsden has posted comments on this change=2E ( http://gerrit=2Eclouder= a=2Eorg:8080/8500 ) Change subject: Pin gen_build_version's git handling t= o typical git dir=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 1: Sorry, didn't realize this was the upstream commit= =2E What I meant to say was we had exactly the same issue where the wrong = impala-lzo bits were getting used=2E The result was exactly the same compi= le failure: hdfs-lzo-text-scanner=2Ecc:589:44: error: no matching function= for call to 'impala::ScannerContext::ReleaseCompletedResources(bool)' c= ontext_->ReleaseCompletedResources(false); -- To view, visit http://gerr= it=2Ecloudera=2Eorg:8080/8500 To unsubscribe, visit http://gerrit=2Eclouder= a=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Ger= rit-MessageType: comment Gerrit-Change-Id: I98870a1cb2073ddcf9ba1620e3801e1= 964930edd Gerrit-Change-Number: 8500 Gerrit-PatchSet: 1 Gerrit-Owner: Phili= p Zeyliger Gerrit-Reviewer: Impala Public Jenkins G= errit-Reviewer: Jim Apple Gerrit-Reviewer: Jo= e McDonnell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer:= Zach Amsden Gerrit-Comment-Date: Mon, 13 Nov 2017= 22:44:59 +0000 Gerrit-HasComments: No --GoASatyFv+4=--