Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6163A200D47 for ; Sat, 11 Nov 2017 01:24:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5FD03160BF2; Sat, 11 Nov 2017 00:24:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A510C160BEE for ; Sat, 11 Nov 2017 01:24:43 +0100 (CET) Received: (qmail 61223 invoked by uid 500); 11 Nov 2017 00:24:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 61211 invoked by uid 99); 11 Nov 2017 00:24:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Nov 2017 00:24:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EDC7B1A4A93 for ; Sat, 11 Nov 2017 00:24:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MMlp-QzhQGqj for ; Sat, 11 Nov 2017 00:24:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5D78760D12 for ; Sat, 11 Nov 2017 00:24:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vAB0Ob2w023142; Sat, 11 Nov 2017 00:24:37 GMT Message-Id: <201711110024.vAB0Ob2w023142@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Sat, 11 Nov 2017 00:24:36 +0000 From: "David Knupp (Code Review)" To: Philip Zeyliger , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Joe McDonnell , Zach Amsden X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6148=3A_Specifying_thirdparty_deps_as_URLs=0A?= X-Gerrit-Change-Id: I4628d86022d4bd8b762313f7056d76416a58b422 X-Gerrit-Change-Number: 8456 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2212a8897e66e1a5c548132d09a8e33e275a0e3b In-Reply-To: References: X-Gerrit-Comment-Date: Sat, 11 Nov 2017 00:24:36 +0000 Reply-To: dknupp@cloudera.com, zamsden@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, joemcdonnell@cloudera.com, philip@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="jr1XjyrA3ME="; charset=UTF-8 archived-at: Sat, 11 Nov 2017 00:24:44 -0000 --jr1XjyrA3ME= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable David Knupp has posted comments on this change=2E ( http://gerrit=2Eclouder= a=2Eorg:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty dep= s as URLs =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 8: > Patch Set 6: > > Well, that's what I get for being clever = with bash=2E I've removed the magical > "unset" for loop and am now unsetti= ng every URL explicitly=2E "It's a big global bag of strings=2E What could= go wrong?" -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8456 T= o unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-P= roject: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit= -Change-Id: I4628d86022d4bd8b762313f7056d76416a58b422 Gerrit-Change-Number:= 8456 Gerrit-PatchSet: 8 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: David Knupp Gerrit-Reviewer: I= mpala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Rev= iewer: Zach Amsden Gerrit-Comment-Date: Sat, 11 No= v 2017 00:24:36 +0000 Gerrit-HasComments: No --jr1XjyrA3ME=--