Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711100700.vAA70xFx019566@ip-10-146-233-104.ec2.internal>
Date: Fri, 10 Nov 2017 07:00:58 +0000
From: "Dimitris Tsirogiannis (Code Review)" <gerrit@cloudera.org>
To: Vuk Ercegovac <vercegovac@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Balazs Jeszenszky <jeszyb@gmail.com>,
        Philip Zeyliger <philip@cloudera.com>,
        Michael Brown <mikeb@cloudera.com>, Alex Behm <alex.behm@cloudera.com>,
        Juan Yu <jyu@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4704=3A_Turns_on_client_connections_when_local_catalog_initialized=2E=0A?=
In-Reply-To: <gerrit.1507075635000.I52b881cba18a7e4533e21a78751c2e35c3d4c8a6@gerrit.cloudera.org>
References: <gerrit.1507075635000.I52b881cba18a7e4533e21a78751c2e35c3d4c8a6@gerrit.cloudera.org>
Reply-To: dtsirogiannis@cloudera.com, impala-cr@cloudera.com,
        marcelk@gmail.com, dhecht@cloudera.com, philip@cloudera.com,
        jyu@cloudera.com, alex.behm@cloudera.com,
        reviews@impala.incubator.apache.org, mikeb@cloudera.com,
        vercegovac@cloudera.com, jeszyb@gmail.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="6GkVuvOG4+4="; charset=UTF-8
archived-at: Fri, 10 Nov 2017 07:01:06 -0000

--6GkVuvOG4+4=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Dimitris Tsirogiannis has posted comments on this change=2E ( http://gerrit=
=2Ecloudera=2Eorg:8080/8202 )

Change subject: IMPALA-4704: Turns on client=
 connections when local catalog initialized=2E
=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E


Patch Set 22: Code-Review+2

(7 comment=
s)

Minor formatting nits=2E Tests seem reasonable to me=2E

http://gerrit=
=2Ecloudera=2Eorg:8080/#/c/8202/22/be/src/service/impala-server=2Ecc
File b=
e/src/service/impala-server=2Ecc:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/=
8202/22/be/src/service/impala-server=2Ecc@1930
PS22, Line 1930: int32_t hs2=
_port) {
fix indentation


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/22/=
be/src/service/impala-server=2Ecc@1948
PS22, Line 1948: ;
remove


http://g=
errit=2Ecloudera=2Eorg:8080/#/c/8202/22/be/src/service/impala-server=2Ecc@1=
980
PS22, Line 1980:       boost::shared_ptr<TProcessor> beeswax_processor(=
new ImpalaServiceProcessor(handler));
nit: long line


http://gerrit=2Eclou=
dera=2Eorg:8080/#/c/8202/22/be/src/service/impalad-main=2Ecc
File be/src/se=
rvice/impalad-main=2Ecc:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/22/b=
e/src/service/impalad-main=2Ecc@88
PS22, Line 88: FLAGS_hs2_port
nit: inden=
tation


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/22/bin/start-impala-c=
luster=2Epy
File bin/start-impala-cluster=2Epy:

http://gerrit=2Ecloudera=
=2Eorg:8080/#/c/8202/22/bin/start-impala-cluster=2Epy@316
PS22, Line 316:  =
 """Waits for a catalog copy to be received by the impalad=2E When its rece=
ived, additionally
nit: long line


http://gerrit=2Ecloudera=2Eorg:8080/#/c=
/8202/22/tests/common/custom_cluster_test_suite=2Epy
File tests/common/cust=
om_cluster_test_suite=2Epy:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/2=
2/tests/common/custom_cluster_test_suite=2Epy@125
PS22, Line 125: cluster_s=
ize=3DCLUSTER_SIZE, num_coordinators=3DNUM_COORDINATORS,
              :   =
                          use_exclusive_coordinators=3DFalse, log_level=3D1=
,
              :                             expected_num_executors=3DCLUS=
TER_SIZE):
indentation


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/22/te=
sts/custom_cluster/test_catalog_wait=2Epy
File tests/custom_cluster/test_ca=
talog_wait=2Epy:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/22/tests/cus=
tom_cluster/test_catalog_wait=2Epy@81
PS22, Line 81: # TODO: add more tests=

             :   # - impalads that are just coordinators
             :   =
# - impalads that are just executors
             :   # - process reincarna=
tion, e=2Eg=2E, healthy impalad crashes and is restarted
remove


-- 
To v=
iew, visit http://gerrit=2Ecloudera=2Eorg:8080/8202
To unsubscribe, visit h=
ttp://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Ger=
rit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52b881cba=
18a7e4533e21a78751c2e35c3d4c8a6
Gerrit-Change-Number: 8202
Gerrit-PatchSet:=
 22
Gerrit-Owner: Vuk Ercegovac <vercegovac@cloudera=2Ecom>
Gerrit-Reviewer=
: Alex Behm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: Balazs Jeszenszky=
 <jeszyb@gmail=2Ecom>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera=2Ecom>
Ge=
rrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera=2Ecom>
Gerrit-=
Reviewer: Juan Yu <jyu@cloudera=2Ecom>
Gerrit-Reviewer: Michael Brown <mike=
b@cloudera=2Ecom>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera=2Ecom>
=
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera=2Ecom>
Gerrit-Comment-D=
ate: Fri, 10 Nov 2017 07:00:58 +0000
Gerrit-HasComments: Yes

--6GkVuvOG4+4=--