Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711090208.vA928XI8029265@ip-10-146-233-104.ec2.internal>
Date: Thu, 9 Nov 2017 02:08:32 +0000
From: "Kim Jin Chul (Code Review)" <gerrit@cloudera.org>
To: Philip Zeyliger <philip@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>,
        Bikramjeet Vig <bikramjeet.vig@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6084=3A_Avoid_using_of_global_namespace_for_llvm=0A?=
In-Reply-To: <gerrit.1510040195000.I7098baff5f746bcc2965583ca99f6188997b733a@gerrit.cloudera.org>
References: <gerrit.1510040195000.I7098baff5f746bcc2965583ca99f6188997b733a@gerrit.cloudera.org>
Reply-To: jinchul@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com,
        tarmstrong@cloudera.com, philip@cloudera.com,
        reviews@impala.incubator.apache.org, bikramjeet.vig@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="4PxDqExoMBo="; charset=UTF-8
archived-at: Thu, 09 Nov 2017 02:08:38 -0000

--4PxDqExoMBo=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Philip Zeyliger, Tim Armstrong, Bikramjeet Vig, 

I'd like you to ree=
xamine a change=2E Please visit

    http://gerrit=2Ecloudera=2Eorg:8080/84=
89

to look at the new patch set (#4)=2E

Change subject: IMPALA-6084: Avoi=
d using of global namespace for llvm
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E

IMPALA-6084: Avoid using of global namespace for =
llvm

There are a large number of places in the backend where
we import eve=
rything from the llvm namespace into the
global namespace=2E (e=2Eg=2E usin=
g namespace llvm;)

Here are the reasons why we don't prefer this:
* It cou=
ld make symbol conflicts if a newly added code
has same symbole name=2E
* I=
t makes code readability uncomfortable=2E We may not
recognize a symbol cam=
e from=2E

We adopt a sequence of namespace specifiers in each use case=2E
=

Change-Id: I7098baff5f746bcc2965583ca99f6188997b733a
---
M be/src/benchmar=
ks/hash-benchmark=2Ecc
M be/src/codegen/codegen-anyval=2Ecc
M be/src/codege=
n/codegen-callgraph=2Ecc
M be/src/codegen/codegen-symbol-emitter=2Ecc
M be/=
src/codegen/codegen-util=2Ecc
M be/src/codegen/instruction-counter-test=2Ec=
c
M be/src/codegen/instruction-counter=2Ecc
M be/src/codegen/llvm-codegen-t=
est=2Ecc
M be/src/codegen/llvm-codegen=2Ecc
M be/src/codegen/llvm-codegen=
=2Eh
M be/src/exec/blocking-join-node=2Ecc
M be/src/exec/exec-node=2Ecc
M b=
e/src/exec/filter-context=2Ecc
M be/src/exec/hash-table=2Ecc
M be/src/exec/=
hdfs-avro-scanner=2Ecc
M be/src/exec/hdfs-parquet-scanner=2Ecc
M be/src/exe=
c/hdfs-scan-node-base=2Ecc
M be/src/exec/hdfs-scanner=2Ecc
M be/src/exec/hd=
fs-sequence-scanner=2Ecc
M be/src/exec/hdfs-text-scanner=2Ecc
M be/src/exec=
/partitioned-aggregation-node=2Ecc
M be/src/exec/partitioned-hash-join-buil=
der=2Ecc
M be/src/exec/partitioned-hash-join-node=2Ecc
M be/src/exec/select=
-node=2Ecc
M be/src/exec/text-converter=2Ecc
M be/src/exec/topn-node=2Ecc
M=
 be/src/exec/union-node=2Ecc
M be/src/exprs/agg-fn-evaluator=2Ecc
M be/src/=
exprs/agg-fn=2Ecc
M be/src/exprs/case-expr=2Ecc
M be/src/exprs/compound-pre=
dicates=2Ecc
M be/src/exprs/expr-codegen-test=2Ecc
M be/src/exprs/expr-test=
=2Ecc
M be/src/exprs/literal=2Ecc
M be/src/exprs/null-literal=2Ecc
M be/src=
/exprs/scalar-expr=2Ecc
M be/src/exprs/scalar-fn-call=2Ecc
M be/src/exprs/s=
lot-ref=2Ecc
M be/src/runtime/descriptors=2Ecc
M be/src/runtime/runtime-sta=
te=2Ecc
M be/src/runtime/types=2Ecc
M be/src/util/tuple-row-compare=2Ecc
42=
 files changed, 1,420 insertions(+), 1,346 deletions(-)


  git pull ssh://=
gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/89/8489/4
-- 
To view=
, visit http://gerrit=2Ecloudera=2Eorg:8080/8489
To unsubscribe, visit http=
://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit=
-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7098baff=
5f746bcc2965583ca99f6188997b733a
Gerrit-Change-Number: 8489
Gerrit-PatchSet=
: 4
Gerrit-Owner: Kim Jin Chul <jinchul@gmail=2Ecom>
Gerrit-Reviewer: Bikra=
mjeet Vig <bikramjeet=2Evig@cloudera=2Ecom>
Gerrit-Reviewer: Philip Zeylige=
r <philip@cloudera=2Ecom>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloude=
ra=2Ecom>

--4PxDqExoMBo=--