Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 67A52200D45 for ; Thu, 9 Nov 2017 01:20:25 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 648AA160C01; Thu, 9 Nov 2017 00:20:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A9860160BDA for ; Thu, 9 Nov 2017 01:20:24 +0100 (CET) Received: (qmail 6537 invoked by uid 500); 9 Nov 2017 00:20:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6526 invoked by uid 99); 9 Nov 2017 00:20:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 00:20:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D9EF1C6343 for ; Thu, 9 Nov 2017 00:20:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kx0_xBc8yNYb for ; Thu, 9 Nov 2017 00:20:22 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id F1F405F30B for ; Thu, 9 Nov 2017 00:20:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA90KLbx025225; Thu, 9 Nov 2017 00:20:21 GMT Message-Id: <201711090020.vA90KLbx025225@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Thu, 9 Nov 2017 00:20:21 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6164=3A_Fix_stale_query_profile_in_TestAlwaysFalseFilter=0A?= X-Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89 X-Gerrit-Change-Number: 8498 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6cdea4af0d8e59ef2bf797b1e2c0bf69a8d62272 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 9 Nov 2017 00:20:21 +0000 Reply-To: twang@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="p9J3uMJmWZM="; charset=UTF-8 archived-at: Thu, 09 Nov 2017 00:20:25 -0000 --p9J3uMJmWZM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tianyi Wang has posted comments on this change=2E ( http://gerrit=2Eclouder= a=2Eorg:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile i= n TestAlwaysFalseFilter =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E Patch Set 2: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080= /#/c/8498/1//COMMIT_MSG Commit Message: http://gerrit=2Ecloudera=2Eorg:808= 0/#/c/8498/1//COMMIT_MSG@13 PS1, Line 13: finalization is performed in Coor= dinator::GetNext after we hit eos=2E > nit: Add "after we hit 'eos'" Done = http://gerrit=2Ecloudera=2Eorg:8080/#/c/8498/1//COMMIT_MSG@13 PS1, Line 13= : fter we hit eos=2E : A bug in Base64Decode related to quer > = Could you briefly mention what the noticeable implications were of this bug= Done -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8498 To uns= ubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Projec= t: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Chan= ge-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89 Gerrit-Change-Number: 8498= Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit= -Reviewer: Sailesh Mukil Gerrit-Reviewer: Tianyi W= ang Gerrit-Comment-Date: Thu, 09 Nov 2017 00:20:21 += 0000 Gerrit-HasComments: Yes --p9J3uMJmWZM=--