Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A3B0200D33 for ; Wed, 8 Nov 2017 23:24:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 08B85160BDA; Wed, 8 Nov 2017 22:24:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5202C1609E0 for ; Wed, 8 Nov 2017 23:23:59 +0100 (CET) Received: (qmail 92823 invoked by uid 500); 8 Nov 2017 22:23:58 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92810 invoked by uid 99); 8 Nov 2017 22:23:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 22:23:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8200018078F for ; Wed, 8 Nov 2017 22:23:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vP83KoGNMGhB for ; Wed, 8 Nov 2017 22:23:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5D9495FB91 for ; Wed, 8 Nov 2017 22:23:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA8MNtZe021075; Wed, 8 Nov 2017 22:23:55 GMT Message-Id: <201711082223.vA8MNtZe021075@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Wed, 8 Nov 2017 22:23:55 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tianyi Wang , Dan Hecht X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4835=3A_Part_1=3A_simplify_I/O_mgr_mem_mgmt=0A?= X-Gerrit-Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1 X-Gerrit-Change-Number: 8414 X-Gerrit-ChangeURL: X-Gerrit-Commit: 78e2d2b1e4cf895a67501a107d29b8218a73a2a3 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 8 Nov 2017 22:23:55 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, twang@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="xWQX+L+9e1A="; charset=UTF-8 archived-at: Wed, 08 Nov 2017 22:24:00 -0000 --xWQX+L+9e1A= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mg= r mem mgmt =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 4: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8414/4/b= e/src/runtime/disk-io-mgr=2Ecc File be/src/runtime/disk-io-mgr=2Ecc: http:= //gerrit=2Ecloudera=2Eorg:8080/#/c/8414/4/be/src/runtime/disk-io-mgr=2Ecc@7= 97 PS4, Line 797: reader->disk_states_[disk_queue->disk_id]=2EDecreme= ntRequestThread(); > That's a good question=2E I don't understand whether i= t's a bug or not=2E It's I spent some more time looking at this and I'm in= creasingly thinking that this isn't the right way to propagate the error=2E= I've been looking at how other errors are propagated to clients and it's d= eeply weird - I think it somehow depends on the cancelled scan range being = repeatedly scheduled until the request context is cancelled=2E -- To vi= ew, visit http://gerrit=2Ecloudera=2Eorg:8080/8414 To unsubscribe, visit ht= tp://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerr= it-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5cb42437d= 11c13bc4a55c3ab426b66777332bd1 Gerrit-Change-Number: 8414 Gerrit-PatchSet: = 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: = Dan Hecht Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerri= t-Comment-Date: Wed, 08 Nov 2017 22:23:55 +0000 Gerrit-HasComments: Yes --xWQX+L+9e1A=--