Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B6304200D33 for ; Wed, 8 Nov 2017 21:57:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B4EFA160BDA; Wed, 8 Nov 2017 20:57:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 059521609E0 for ; Wed, 8 Nov 2017 21:57:00 +0100 (CET) Received: (qmail 28777 invoked by uid 500); 8 Nov 2017 20:57:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 28766 invoked by uid 99); 8 Nov 2017 20:56:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 20:56:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2633F1A3561 for ; Wed, 8 Nov 2017 20:56:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KYw9m6vh2CDg for ; Wed, 8 Nov 2017 20:56:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 90B5661509 for ; Wed, 8 Nov 2017 20:56:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA8Kutq2018094; Wed, 8 Nov 2017 20:56:55 GMT Message-Id: <201711082056.vA8Kutq2018094@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 9 Date: Wed, 8 Nov 2017 20:56:55 +0000 From: "Philip Zeyliger (Code Review)" To: Gabor Kaszab , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Tim Armstrong , Lars Volker , Attila Jeges , Laszlo Gaal , Csaba Ringhofer , Zoltan Borok-Nagy X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2181=3A_Add_query_option_levels_for_display=0A?= X-Gerrit-Change-Id: I75720d0d454527e1a0ed19bb43cf9e4f018ce1d1 X-Gerrit-Change-Number: 8447 X-Gerrit-ChangeURL: X-Gerrit-Commit: d33a68e0eea717587f0579f138d89f996449776e In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 8 Nov 2017 20:56:55 +0000 Reply-To: philip@cloudera.com, impala-cr@cloudera.com, boroknagyz@cloudera.com, gaborkaszab@cloudera.com, lv@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, tarmstrong@cloudera.com, laszlo.gaal@cloudera.com, csringhofer@cloudera.com, attilaj@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="Gll94E5Pr24="; charset=UTF-8 archived-at: Wed, 08 Nov 2017 20:57:01 -0000 --Gll94E5Pr24= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo= udera=2Eorg:8080/8447 ) Change subject: IMPALA-2181: Add query option leve= ls for display =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 9: (1 comment) I'm still a little weirded out that we want "= SET" to behave differently in the impala-shell and in HS2=2E Tim/Dan: you o= k with it? http://gerrit=2Ecloudera=2Eorg:8080/#/c/8447/9/common/thrift/be= eswax=2Ethrift File common/thrift/beeswax=2Ethrift: http://gerrit=2Ecloude= ra=2Eorg:8080/#/c/8447/9/common/thrift/beeswax=2Ethrift@103 PS9, Line 103: = 4: optional byte level Why is this a byte? Shouldn't this be an enum? = -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8447 To unsubscribe,= visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala= -ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7= 5720d0d454527e1a0ed19bb43cf9e4f018ce1d1 Gerrit-Change-Number: 8447 Gerrit-P= atchSet: 9 Gerrit-Owner: Gabor Kaszab Gerrit-R= eviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringh= ofer Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Gabor Kaszab Gerrit= -Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit= -Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Dat= e: Wed, 08 Nov 2017 20:56:55 +0000 Gerrit-HasComments: Yes --Gll94E5Pr24=--