Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D8955200D33 for ; Wed, 8 Nov 2017 14:24:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D70F6160BE0; Wed, 8 Nov 2017 13:24:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2888C160BDA for ; Wed, 8 Nov 2017 14:24:44 +0100 (CET) Received: (qmail 61950 invoked by uid 500); 8 Nov 2017 13:24:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 61939 invoked by uid 99); 8 Nov 2017 13:24:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 13:24:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5873D1807FE for ; Wed, 8 Nov 2017 13:24:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_MANYTO=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vrQbvD_MdQsI for ; Wed, 8 Nov 2017 13:24:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5A8865F30B for ; Wed, 8 Nov 2017 13:24:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA8DObJU007899; Wed, 8 Nov 2017 13:24:37 GMT Message-Id: <201711081324.vA8DObJU007899@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Wed, 8 Nov 2017 13:24:36 +0000 From: "Zoltan Borok-Nagy (Code Review)" To: Michael Ho , Thomas Tauber-Marshall , Laszlo Gaal , Gabor Kaszab , Attila Jeges , Tim Armstrong , Csaba Ringhofer , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2248=3A_Make_idle_session_timeout_a_query_option=0A?= X-Gerrit-Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e X-Gerrit-Change-Number: 8490 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2e56331158a3572562c9fb82d8a66ea4e6431c58 In-Reply-To: References: Reply-To: boroknagyz@cloudera.com, impala-cr@cloudera.com, gaborkaszab@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, tarmstrong@cloudera.com, laszlo.gaal@cloudera.com, csringhofer@cloudera.com, attilaj@cloudera.com, tmarshall@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="BijaiiNPyV0="; charset=UTF-8 archived-at: Wed, 08 Nov 2017 13:24:45 -0000 --BijaiiNPyV0= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila= Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a chang= e=2E Please visit http://gerrit=2Ecloudera=2Eorg:8080/8490 to look at= the new patch set (#5)=2E Change subject: IMPALA-2248: Make idle_session_= timeout a query option =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E IMPALA-2248: Make idle_session_timeout a query option This comm= it makes idle_session_timeout a query option=2E idle_session_timeout curren= tly can be set as a command line option, which will be the default timeout = for sessions=2E HS2 sessions can override it with a smaller value by settin= g it in the configuration overlay of HS2 OpenSession()=2E However, we can'= t override idle_session_timeout for JDBC/ODBC connections, because we canno= t put this in the connection string=2E This commit is a workaround for thi= s problem, it allows JDBC/ODBC connections to set the session timeout as a = query option with the SET statement=2E I created an automated test case in= JdbcTest=2Ejava based on test_hs2=2Epy::test_concurrent_session_mixed_idle= _timeout=2E Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e --- M be/= src/service/client-request-state=2Ecc M be/src/service/client-request-state= =2Eh M be/src/service/impala-hs2-server=2Ecc M be/src/service/impala-server= =2Ecc M be/src/service/impala-server=2Eh M be/src/service/query-options=2Ec= c M be/src/service/query-options=2Eh M common/thrift/ImpalaInternalService= =2Ethrift M common/thrift/ImpalaService=2Ethrift M fe/src/test/java/org/apa= che/impala/service/JdbcTest=2Ejava A fe/src/test/java/org/apache/impala/uti= l/Metrics=2Ejava 11 files changed, 256 insertions(+), 32 deletions(-) g= it pull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/90/8490= /5 -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8490 To unsubscri= be, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Imp= ala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change= -Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e Gerrit-Change-Number: 8490 G= errit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: = Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab = Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Ho Gerrit-Revi= ewer: Thomas Tauber-Marshall Gerrit-Reviewer: Ti= m Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy = --BijaiiNPyV0=--