Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 59FE6200D35 for ; Tue, 7 Nov 2017 18:30:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 58C42160BED; Tue, 7 Nov 2017 17:30:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F270160BEB for ; Tue, 7 Nov 2017 18:30:01 +0100 (CET) Received: (qmail 91366 invoked by uid 500); 7 Nov 2017 17:30:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 91331 invoked by uid 99); 7 Nov 2017 17:30:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2017 17:30:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B9B1918E134 for ; Tue, 7 Nov 2017 17:29:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WvMB41aazltG for ; Tue, 7 Nov 2017 17:29:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C3A4C5FCC7 for ; Tue, 7 Nov 2017 17:29:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA7HTvte014787; Tue, 7 Nov 2017 17:29:57 GMT Message-Id: <201711071729.vA7HTvte014787@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 7 Nov 2017 17:29:57 +0000 From: "David Knupp (Code Review)" To: Philip Zeyliger , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Joe McDonnell , Zach Amsden X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6148=3A_Specifying_thirdparty_deps_as_URLs=0A?= X-Gerrit-Change-Id: I4628d86022d4bd8b762313f7056d76416a58b422 X-Gerrit-Change-Number: 8456 X-Gerrit-ChangeURL: X-Gerrit-Commit: b44910118f8756991de144e397e393c3c55f9e25 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 7 Nov 2017 17:29:57 +0000 Reply-To: dknupp@cloudera.com, zamsden@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, joemcdonnell@cloudera.com, philip@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="lsrabluTq1I="; charset=UTF-8 archived-at: Tue, 07 Nov 2017 17:30:02 -0000 --lsrabluTq1I= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable David Knupp has posted comments on this change=2E ( http://gerrit=2Eclouder= a=2Eorg:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty dep= s as URLs =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 3: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8456/2/b= in/bootstrap_toolchain=2Epy File bin/bootstrap_toolchain=2Epy: http://gerr= it=2Ecloudera=2Eorg:8080/#/c/8456/2/bin/bootstrap_toolchain=2Epy@112 PS2, L= ine 112: return v > Why not cache v instead? Also, would it be approp= riate to cache the value as an attribute of Package() instead? -- To vi= ew, visit http://gerrit=2Ecloudera=2Eorg:8080/8456 To unsubscribe, visit ht= tp://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerr= it-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4628d86022= d4bd8b762313f7056d76416a58b422 Gerrit-Change-Number: 8456 Gerrit-PatchSet: = 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Da= vid Knupp Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Zach Amsden Gerrit-Comment-Date= : Tue, 07 Nov 2017 17:29:57 +0000 Gerrit-HasComments: Yes --lsrabluTq1I=--