Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5E63B200D43 for ; Tue, 7 Nov 2017 02:20:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5CFEF160BFF; Tue, 7 Nov 2017 01:20:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A27EB160BEC for ; Tue, 7 Nov 2017 02:20:57 +0100 (CET) Received: (qmail 99898 invoked by uid 500); 7 Nov 2017 01:20:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 99887 invoked by uid 99); 7 Nov 2017 01:20:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2017 01:20:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A50D818AD8E for ; Tue, 7 Nov 2017 01:20:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3xDsiCASNlRq for ; Tue, 7 Nov 2017 01:20:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8085A5FAF3 for ; Tue, 7 Nov 2017 01:20:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA71KrpN001862; Tue, 7 Nov 2017 01:20:53 GMT Message-Id: <201711070120.vA71KrpN001862@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Tue, 7 Nov 2017 01:20:53 +0000 From: "Tim Armstrong (Code Review)" To: Tim Wood , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Brown , Greg Rahn X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6155=3A_Ensure_TPC-DS_result_orders_can=27t_vary=2E=0A?= X-Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c X-Gerrit-Change-Number: 8484 X-Gerrit-ChangeURL: X-Gerrit-Commit: ea8ad3469c21b099c5b32c5905effba9b66e6dfe In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 7 Nov 2017 01:20:53 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, twood@cloudera.com, reviews@impala.incubator.apache.org, grahn@cloudera.com, mikeb@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="T28KCrjXiCQ="; charset=UTF-8 archived-at: Tue, 07 Nov 2017 01:20:58 -0000 --T28KCrjXiCQ= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8484 ) Change subject: IMPALA-6155: Ensure TPC-DS result or= ders can't vary=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 2: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c= /8484/2/testdata/workloads/tpcds/queries/tpcds-q77a=2Etest File testdata/wo= rkloads/tpcds/queries/tpcds-q77a=2Etest: http://gerrit=2Ecloudera=2Eorg:80= 80/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a=2Etest@120 PS2, L= ine 120: ---- RESULTS Another option is to use the VERIFY_IS_EQUAL_SORTED v= erifier instead of modifying the query=2E That's not very strict but might = be better than diverging the queries further from the official TPC-DS versi= ons=2E I haven't been following that closely so not sure what the general a= pproach has been with modifications vs changing the verification logic=2E = -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8484 To unsubscrib= e, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impa= la-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: = Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c Gerrit-Change-Number: 8484 Gerrit= -PatchSet: 2 Gerrit-Owner: Tim Wood Gerrit-Reviewer:= Greg Rahn Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Ger= rit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 07 = Nov 2017 01:20:53 +0000 Gerrit-HasComments: Yes --T28KCrjXiCQ=--