Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B0BB0200D36 for ; Mon, 6 Nov 2017 22:54:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AF3F5160BEC; Mon, 6 Nov 2017 21:54:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 00CC0160BD5 for ; Mon, 6 Nov 2017 22:54:14 +0100 (CET) Received: (qmail 66852 invoked by uid 500); 6 Nov 2017 21:54:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 66841 invoked by uid 99); 6 Nov 2017 21:54:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Nov 2017 21:54:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 31DB8C9E73 for ; Mon, 6 Nov 2017 21:54:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id p_J4gyTGry_S for ; Mon, 6 Nov 2017 21:54:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 58BCB5FB91 for ; Mon, 6 Nov 2017 21:54:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA6LsBJQ022894; Mon, 6 Nov 2017 21:54:11 GMT Message-Id: <201711062154.vA6LsBJQ022894@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Mon, 6 Nov 2017 21:54:10 +0000 From: "Alex Behm (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Mostafa Mokhtar , Thomas Tauber-Marshall X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6151=3A_add_query-level_fragment/backend_counters=0A?= X-Gerrit-Change-Id: I3df350414733e98d1ec28adc1c98f45bb0c4e3e9 X-Gerrit-Change-Number: 8461 X-Gerrit-ChangeURL: X-Gerrit-Commit: da3fb61436f42cb31b0d50b98031d0baf6ae8a28 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 6 Nov 2017 21:54:10 +0000 Reply-To: alex.behm@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, mmokhtar@cloudera.com, tmarshall@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="joDTFWWJFD0="; charset=UTF-8 archived-at: Mon, 06 Nov 2017 21:54:15 -0000 --joDTFWWJFD0= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alex Behm has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/b= ackend counters =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E Patch Set 3: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/84= 61/3/be/src/service/impala-server=2Ecc File be/src/service/impala-server=2E= cc: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8461/3/be/src/service/impala-s= erver=2Ecc@1052 PS3, Line 1052: ImpaladMetrics::NUM_QUERIES_REGISTERED->I= ncrement(-1L); > At this point the query has been removed from all tracking= structures so I My understanding is that archiving can take a long time (= e=2Eg=2E huge profile), so it means this metric may be inaccurate for an ex= tended period=2E I agree it probably doesn't matter that much, but why not= try to make the counter as accurate as possible=2E There is a non-trivial = amount of work to be done at this point=2E -- To view, visit http://ger= rit=2Ecloudera=2Eorg:8080/8461 To unsubscribe, visit http://gerrit=2Ecloude= ra=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Ge= rrit-MessageType: comment Gerrit-Change-Id: I3df350414733e98d1ec28adc1c98f4= 5bb0c4e3e9 Gerrit-Change-Number: 8461 Gerrit-PatchSet: 3 Gerrit-Owner: Tim = Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Thomas Tauber-Marshall Gerri= t-Reviewer: Tim Armstrong Gerrit-Comment-Date: = Mon, 06 Nov 2017 21:54:10 +0000 Gerrit-HasComments: Yes --joDTFWWJFD0=--