Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711061748.vA6HmCn8014332@ip-10-146-233-104.ec2.internal>
Date: Mon, 6 Nov 2017 17:48:12 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: Thomas Tauber-Marshall <tmarshall@cloudera.com>,
        Mostafa Mokhtar <mmokhtar@cloudera.com>,
        Alex Behm <alex.behm@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6151=3A_add_query-level_fragment/backend_counters=0A?=
In-Reply-To: <gerrit.1509735032000.I3df350414733e98d1ec28adc1c98f45bb0c4e3e9@gerrit.cloudera.org>
References: <gerrit.1509735032000.I3df350414733e98d1ec28adc1c98f45bb0c4e3e9@gerrit.cloudera.org>
Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com,
        mmokhtar@cloudera.com, tmarshall@cloudera.com, alex.behm@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="050mNcqSW4A="; charset=UTF-8
archived-at: Mon, 06 Nov 2017 17:48:20 -0000

--050mNcqSW4A=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Thomas Tauber-Marshall, Mostafa Mokhtar, Alex Behm, 

I'd like you to=
 reexamine a change=2E Please visit

    http://gerrit=2Ecloudera=2Eorg:808=
0/8461

to look at the new patch set (#4)=2E

Change subject: IMPALA-6151: =
add query-level fragment/backend counters
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPALA-6151: add query-level fragment/backend =
counters

This adds NumBackends, NumFragments and NumFragmentInstances
coun=
ters to the query profile to make it easier to manually or
programmatically=
 analyse the query=2E

Also add a num-queries-registered metric to track th=
e number
of queries that have been executed but are not yet unregistered=2E=


Testing:
Ran "select count(*) from alltypessmall" and checked profile:

 =
   Backend startup latencies: Count: 3, min / max: 1ms / 1ms, 25th %-ile: 1=
ms, 50th %-ile: 1ms, 75th %-ile: 1ms, 90th %-ile: 1ms, 95th %-ile: 1ms, 99=
=2E9th %-ile: 1ms
    Per Node Peak Memory Usage: tarmstrong-box:22000(1=2E=
10 MB) tarmstrong-box:22001(1=2E02 MB) tarmstrong-box:22002(1=2E02 MB)
    =
 - FiltersReceived: 0 (0)
     - FinalizationTimer: 0=2E000ns
     - NumBac=
kends: 3 (3)
     - NumFragmentInstances: 4 (4)
     - NumFragments: 2 (2)
=

Ran some queries and manually checked the num-queries-registered metric
on=
 the /metrics page when the queries were running and after they
finished=2E=


Change-Id: I3df350414733e98d1ec28adc1c98f45bb0c4e3e9
---
M be/src/runtime=
/coordinator=2Ecc
M be/src/service/impala-server=2Ecc
M be/src/util/impalad=
-metrics=2Ecc
M be/src/util/impalad-metrics=2Eh
M common/thrift/metrics=2Ej=
son
5 files changed, 36 insertions(+), 5 deletions(-)


  git pull ssh://ge=
rrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/61/8461/4
-- 
To view, =
visit http://gerrit=2Ecloudera=2Eorg:8080/8461
To unsubscribe, visit http:/=
/gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-B=
ranch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3df3504147=
33e98d1ec28adc1c98f45bb0c4e3e9
Gerrit-Change-Number: 8461
Gerrit-PatchSet: =
4
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera=2Ecom>
Gerrit-Reviewer: =
Alex Behm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: Mostafa Mokhtar <mm=
okhtar@cloudera=2Ecom>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@c=
loudera=2Ecom>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera=2Ecom>

--050mNcqSW4A=--