Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 19672200D34 for ; Fri, 3 Nov 2017 23:36:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 17DF4160BFB; Fri, 3 Nov 2017 22:36:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5DAAD160BDE for ; Fri, 3 Nov 2017 23:36:16 +0100 (CET) Received: (qmail 77898 invoked by uid 500); 3 Nov 2017 22:36:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 77887 invoked by uid 99); 3 Nov 2017 22:36:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 22:36:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8B3FFDFBB6 for ; Fri, 3 Nov 2017 22:36:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lcpn5gNCN2RW for ; Fri, 3 Nov 2017 22:36:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E99D75FBEA for ; Fri, 3 Nov 2017 22:36:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA3MaBlG017172; Fri, 3 Nov 2017 22:36:11 GMT Message-Id: <201711032236.vA3MaBlG017172@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Fri, 3 Nov 2017 22:36:11 +0000 From: "Csaba Ringhofer (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6054=3A_Parquet_dictionary_pages_should_be_freed_on_dictionary_construction=0A?= X-Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004 X-Gerrit-Change-Number: 8436 X-Gerrit-ChangeURL: X-Gerrit-Commit: 52849028c3fa9151f06a04ccbd1910f5af44e1fc In-Reply-To: References: Reply-To: csringhofer@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="cdo+VLenHHY="; charset=UTF-8 archived-at: Fri, 03 Nov 2017 22:36:17 -0000 --cdo+VLenHHY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Lars Volker, I'd like you to reexamine a change=2E Please visit = http://gerrit=2Ecloudera=2Eorg:8080/8436 to look at the new patch set (#= 4)=2E Change subject: IMPALA-6054: Parquet dictionary pages should be free= d on dictionary construction =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E IMPALA-6054: Parquet dictionary pages should be freed on d= ictionary construction During dictionary constructon, most types are copie= d from the parquet dictionary page, but StringValues keep pointers to it=2E= In this case, the dictionary page must be kept and attached to the last ro= w batch that references it=2E In case of other types, it is safe do delete = the dictionary page after the construction of the dictionary=2E This patch= contains two optimizations: - dictionary pages are deleted as soon as poss= ible for non string types - in non-compressed and non-string case, an unnec= essary copy is avoided Change-Id: I4d9d5f4da1028d961155dafdac0028a1c364100= 4 --- M be/src/exec/parquet-column-readers=2Ecc 1 file changed, 35 insertio= ns(+), 18 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/Imp= ala-ASF refs/changes/36/8436/4 -- To view, visit http://gerrit=2Ecloudera= =2Eorg:8080/8436 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/= settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageTy= pe: newpatchset Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004= Gerrit-Change-Number: 8436 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofe= r Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker --cdo+VLenHHY=--