Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C58BE200D34 for ; Fri, 3 Nov 2017 18:45:22 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C3E56160BFB; Fri, 3 Nov 2017 17:45:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 154EA160BDE for ; Fri, 3 Nov 2017 18:45:21 +0100 (CET) Received: (qmail 92834 invoked by uid 500); 3 Nov 2017 17:45:21 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92822 invoked by uid 99); 3 Nov 2017 17:45:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 17:45:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6791F180782 for ; Fri, 3 Nov 2017 17:45:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id w4dU39Yss3Wm for ; Fri, 3 Nov 2017 17:45:17 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E86035FDD4 for ; Fri, 3 Nov 2017 17:45:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA3HjGA6005672; Fri, 3 Nov 2017 17:45:16 GMT Message-Id: <201711031745.vA3HjGA6005672@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 1 Date: Fri, 3 Nov 2017 17:45:16 +0000 From: "Tim Armstrong (Code Review)" To: Zoltan Borok-Nagy , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Philip Zeyliger X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6134=3A_Update_code_base_to_use_impala=3A=3AConditionVariable=0A?= X-Gerrit-Change-Id: I3085c6dcb42350b61244df6e7f091a1e7db356c9 X-Gerrit-Change-Number: 8428 X-Gerrit-ChangeURL: X-Gerrit-Commit: a531cbcb87c9659d325638666b5b1b879592ac94 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 3 Nov 2017 17:45:16 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, boroknagyz@cloudera.com, marcelk@gmail.com, philip@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="rtbvTdF34V8="; charset=UTF-8 archived-at: Fri, 03 Nov 2017 17:45:23 -0000 --rtbvTdF34V8= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8428 ) Change subject: IMPALA-6134: Update code base to use= impala::ConditionVariable =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Patch Set 1: I don't think it's necessary to unit-test it, = given it's a thin wrapper=2E The test code would be more complex than the p= roduct code=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/842= 8 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerri= t-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Ger= rit-Change-Id: I3085c6dcb42350b61244df6e7f091a1e7db356c9 Gerrit-Change-Numb= er: 8428 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Philip Zeyliger Gerri= t-Reviewer: Tim Armstrong Gerrit-Reviewer: Zolt= an Borok-Nagy Gerrit-Comment-Date: Fri, 03 Nov = 2017 17:45:16 +0000 Gerrit-HasComments: No --rtbvTdF34V8=--