Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 630F2200D3E for ; Thu, 2 Nov 2017 00:29:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 61915160BFA; Wed, 1 Nov 2017 23:29:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A71C9160BEA for ; Thu, 2 Nov 2017 00:29:11 +0100 (CET) Received: (qmail 64169 invoked by uid 500); 1 Nov 2017 23:29:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 64158 invoked by uid 99); 1 Nov 2017 23:29:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 23:29:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 975AD180857 for ; Wed, 1 Nov 2017 23:29:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id uy1aTAO04daf for ; Wed, 1 Nov 2017 23:29:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1EE9A60E74 for ; Wed, 1 Nov 2017 23:29:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA1NT5v8001770; Wed, 1 Nov 2017 23:29:05 GMT Message-Id: <201711012329.vA1NT5v8001770@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Wed, 1 Nov 2017 23:29:04 +0000 From: "Tim Armstrong (Code Review)" To: Bikramjeet Vig , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Lars Volker , Dan Hecht X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2494=3A_Support_for_byte_array_encoded_decimals_in_Parquet_scanner=0A?= X-Gerrit-Change-Id: I2c0e881045109f337fecba53fec21f9cfb9e619e X-Gerrit-Change-Number: 7822 X-Gerrit-ChangeURL: X-Gerrit-Commit: b759ded4e0565ddaec043c3dc3ba84bbb96743ca In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 1 Nov 2017 23:29:04 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, reviews@impala.incubator.apache.org, bikramjeet.vig@cloudera.com, mjacobs@apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="HnfFnyHvu1Y="; charset=UTF-8 archived-at: Wed, 01 Nov 2017 23:29:12 -0000 --HnfFnyHvu1Y= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/7822 ) Change subject: IMPALA-2494: Support for byte array = encoded decimals in Parquet scanner =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E Patch Set 8: Code-Review+2 (1 comment) http://ger= rit=2Ecloudera=2Eorg:8080/#/c/7822/7/be/src/exec/parquet-plain-test=2Ecc Fi= le be/src/exec/parquet-plain-test=2Ecc: http://gerrit=2Ecloudera=2Eorg:808= 0/#/c/7822/7/be/src/exec/parquet-plain-test=2Ecc@33 PS7, Line 33: int Encod= e(const InternalType& t, int encoded_byte_size, uint8_t* buffer, > This tes= t suite basically takes a test value and its expected size and firs Oh ok, = thanks for the explanation=2E I think we should also add a comment mentioni= ng that this doesn't exactly implement the Parquet spec, since the parquet = spec would require that it remove leading zero bytes=2E -- To view, vis= it http://gerrit=2Ecloudera=2Eorg:8080/7822 To unsubscribe, visit http://ge= rrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Bran= ch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c0e881045109f337= fecba53fec21f9cfb9e619e Gerrit-Change-Number: 7822 Gerrit-PatchSet: 8 Gerri= t-Owner: Bikramjeet Vig Gerrit-Reviewer: = Bikramjeet Vig Gerrit-Reviewer: Dan Hecht= Gerrit-Reviewer: Lars Volker G= errit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim = Armstrong Gerrit-Comment-Date: Wed, 01 Nov 2017= 23:29:04 +0000 Gerrit-HasComments: Yes --HnfFnyHvu1Y=--