Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201711012021.vA1KLM0o021925@ip-10-146-233-104.ec2.internal>
Date: Wed, 1 Nov 2017 20:21:22 +0000
From: "Zoram Thanga (Code Review)" <gerrit@cloudera.org>
To: Zoram Thanga <zoram@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Michael Ho <kwho@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5599=3A_Clean_up_references_to_TimestampValue_in_be/src=2E=0A?=
In-Reply-To: <gerrit.1508281037000.I642a1d713597826bb7c15cd2ecb6638cb813a02c@gerrit.cloudera.org>
References: <gerrit.1508281037000.I642a1d713597826bb7c15cd2ecb6638cb813a02c@gerrit.cloudera.org>
Reply-To: zoram@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com,
        dhecht@cloudera.com, kwho@cloudera.com, zoram@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="5t0VjcU54Oo="; charset=UTF-8
archived-at: Wed, 01 Nov 2017 20:21:35 -0000

--5t0VjcU54Oo=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Zoram Thanga has posted comments on this change=2E ( http://gerrit=2Ecloude=
ra=2Eorg:8080/8305 )

Change subject: IMPALA-5599: Clean up references to T=
imestampValue in be/src=2E
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E


Patch Set 11:

(3 comments)

http://gerrit=2Ecloudera=2Eorg:=
8080/#/c/8305/11/be/src/service/client-request-state=2Eh
File be/src/servic=
e/client-request-state=2Eh:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8305/1=
1/be/src/service/client-request-state=2Eh@342
PS11, Line 342: start_time_us=
_, end_time_us_;
> These two may need to be initialized=2E

https://gerrit=
=2Ecloudera=2Eorg/#/c/8430/


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8305/=
11/be/src/service/impala-http-handler=2Ecc
File be/src/service/impala-http-=
handler=2Ecc:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8305/11/be/src/servi=
ce/impala-http-handler=2Ecc@303
PS11, Line 303: record=2Eend_time_us - reco=
rd=2Estart_time_us;
> This may be broken if end_time_us is not set yet=2E T=
he old code will use the
Fixing via https://gerrit=2Ecloudera=2Eorg/#/c/843=
0/


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8305/11/be/src/service/impala-=
server=2Eh
File be/src/service/impala-server=2Eh:

http://gerrit=2Ecloudera=
=2Eorg:8080/#/c/8305/11/be/src/service/impala-server=2Eh@622
PS11, Line 622=
:     /// Start and end time of the query, in Unix microseconds=2E
        =
      :     int64_t start_time_us, end_time_us;
> Can these be const ? They=
 are always initialized in the constructor, right 
The default constructor =
does not handle this well if we make them constants=2E We'll have to make a=
ll/most of the other fields constant as well if we are going to fix this=2E=


-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8305
To unsubscr=
ibe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Im=
pala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id=
: I642a1d713597826bb7c15cd2ecb6638cb813a02c
Gerrit-Change-Number: 8305
Gerr=
it-PatchSet: 11
Gerrit-Owner: Zoram Thanga <zoram@cloudera=2Ecom>
Gerrit-Re=
viewer: Dan Hecht <dhecht@cloudera=2Ecom>
Gerrit-Reviewer: Impala Public Je=
nkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera=2Ecom>
Gerrit-Reviewer: Zo=
ram Thanga <zoram@cloudera=2Ecom>
Gerrit-Comment-Date: Wed, 01 Nov 2017 20:=
21:22 +0000
Gerrit-HasComments: Yes

--5t0VjcU54Oo=--