Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BE5B3200D2F for ; Wed, 1 Nov 2017 17:16:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BCD86160BEA; Wed, 1 Nov 2017 16:16:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0E211160BE6 for ; Wed, 1 Nov 2017 17:16:48 +0100 (CET) Received: (qmail 21973 invoked by uid 500); 1 Nov 2017 16:16:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 21962 invoked by uid 99); 1 Nov 2017 16:16:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 16:16:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 32C3118060F for ; Wed, 1 Nov 2017 16:16:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZbLJVxtpLGxZ for ; Wed, 1 Nov 2017 16:16:46 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 9C62760F58 for ; Wed, 1 Nov 2017 16:16:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA1GGhG2013312; Wed, 1 Nov 2017 16:16:43 GMT Message-Id: <201711011616.vA1GGhG2013312@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Wed, 1 Nov 2017 16:16:43 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: anujphadke X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6137=3A_fix_text_scanner_split_delim_mem_mgmt=0A?= X-Gerrit-Change-Id: Iddbb5cf6acc8f0b0e0b4c205c334f21e03d06f1c X-Gerrit-Change-Number: 8438 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4ad9a72c9e5faca5e79093a49fb13359ca9215aa In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 1 Nov 2017 16:16:43 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, aphadke@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="oNExOnU8KFk="; charset=UTF-8 archived-at: Wed, 01 Nov 2017 16:16:49 -0000 --oNExOnU8KFk= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8438 ) Change subject: IMPALA-6137: fix text scanner split = delim mem mgmt =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 2: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8438/= 2//COMMIT_MSG Commit Message: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8438= /2//COMMIT_MSG@9 PS2, Line 9: The bug was that the buffer pointed to by byt= e_buffer_ could be freed by > Do you mean byte_buffer_ptr_? Yeah I will fix= in the next iteration=2E -- To view, visit http://gerrit=2Ecloudera=2E= org:8080/8438 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/set= tings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType:= comment Gerrit-Change-Id: Iddbb5cf6acc8f0b0e0b4c205c334f21e03d06f1c Gerrit= -Change-Number: 8438 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-Comment-Da= te: Wed, 01 Nov 2017 16:16:43 +0000 Gerrit-HasComments: Yes --oNExOnU8KFk=--