Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 20A87200D2F for ; Wed, 1 Nov 2017 17:02:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1F1AD160BEA; Wed, 1 Nov 2017 16:02:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 63185160BE6 for ; Wed, 1 Nov 2017 17:02:34 +0100 (CET) Received: (qmail 60636 invoked by uid 500); 1 Nov 2017 16:02:33 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 60625 invoked by uid 99); 1 Nov 2017 16:02:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 16:02:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 89C90180705 for ; Wed, 1 Nov 2017 16:02:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 9y5wtr9lc5lq for ; Wed, 1 Nov 2017 16:02:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D709960F9F for ; Wed, 1 Nov 2017 16:02:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vA1G2JTb013166; Wed, 1 Nov 2017 16:02:20 GMT Message-Id: <201711011602.vA1G2JTb013166@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Wed, 1 Nov 2017 16:02:19 +0000 From: "Philip Zeyliger (Code Review)" To: Zoram Thanga , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6136=3A_Part_1=3A_Query_duration_should_not_be_normally_negative=2E=0A?= X-Gerrit-Change-Id: Ib6f971ebd5f0f00f3e38df0495692ffe9d52ef90 X-Gerrit-Change-Number: 8430 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8c0496ec586f66f74f03960ad69da478e48f3c6a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 1 Nov 2017 16:02:19 +0000 Reply-To: philip@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, kwho@cloudera.com, zoram@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="amu+C2W4EWE="; charset=UTF-8 archived-at: Wed, 01 Nov 2017 16:02:35 -0000 --amu+C2W4EWE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo= udera=2Eorg:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duratio= n should not be normally negative=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E Patch Set 2: (1 comment) http://gerrit=2Ecloud= era=2Eorg:8080/#/c/8430/2/be/src/service/impala-http-handler=2Ecc File be/s= rc/service/impala-http-handler=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/#= /c/8430/2/be/src/service/impala-http-handler=2Ecc@303 PS2, Line 303: // r= ecord=2Eend_time_us might still be zero if the query is not yet done nit: C= ould you update the following comment in client-request-state=2Eh and impal= a-server=2Eh (once for ClientRequestState, once for QueryStateRecord) to sa= y something about how 0 is a special value=2E /// Start/end time of the= query, in Unix microseconds=2E int64_t start_time_us_, end_time_us_; = -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8430 To unsubscribe,= visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala= -ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib= 6f971ebd5f0f00f3e38df0495692ffe9d52ef90 Gerrit-Change-Number: 8430 Gerrit-P= atchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewe= r: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit= -Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 01= Nov 2017 16:02:19 +0000 Gerrit-HasComments: Yes --amu+C2W4EWE=--