impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5362 : Preserve case-sensitivity in field titles
Date Wed, 15 Nov 2017 09:05:47 GMT
ydjainopensource@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8544


Change subject: IMPALA-5362 : Preserve case-sensitivity in field titles
......................................................................

IMPALA-5362 : Preserve case-sensitivity in field titles

To preserve case sensitivity in column labels , this patch modifies the getColumnLabel()
method of the SelectListitem class to return original string. However since internally
all identifiers are represented in lowercase a few minor changes have been made to
SelectStmt.java.lowercase "null" was causing union test to fail hence replaced it with "NULL"

Change-Id: Ia574f0b7d5bdbebace270ce4079632bf29b3f00e
---
M fe/src/main/java/org/apache/impala/analysis/SelectListItem.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M testdata/workloads/functional-planner/queries/PlannerTest/union.test
3 files changed, 16 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/8544/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia574f0b7d5bdbebace270ce4079632bf29b3f00e
Gerrit-Change-Number: 8544
Gerrit-PatchSet: 1
Gerrit-Owner: ydjainopensource@gmail.com

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message