impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Date Thu, 30 Nov 2017 19:57:42 GMT
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )

Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc
File be/src/runtime/krpc-data-stream-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201
PS1, Line 201:     ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id);
> why doesn't the same argument hold in the non-krpc case. (I don't feel too 
We didn't feed this error code back to the sender in the non-krpc case yet. Don't think we
do anything for IMPALA-3990 in the non-krpc case.



-- 
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 19:57:42 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message