impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0
Date Thu, 30 Nov 2017 00:35:49 GMT
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
> A long shot, admittedly; I think you're OK with 2nd row <=21.98. :)
I think it should be fine; if it changes radically, we'd probably like to know why anyway.


http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
> why not use column regex like in the other tests in this file?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:35:49 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message